Skip to content

Conversation

@Godmartinz
Copy link
Member

@Godmartinz Godmartinz commented May 14, 2025

This gives users the option to require serials by asset model.
This can be done via each model individually, or through bulk editing models
Model edit:
image
Bulk Model edit:
image

I was concerned with "What if you update an asset model to require serials, how do we deal with that retroactively?" My solution is not to make validation fail if you update an asset w/o a serial, but to provide a 'warning' message that that asset needs a serial appended. it is an undertaking that a user should be prepared to fill.

Asset Update:
image
(If a bad user deletes the serial, that info is readily available in the history log of the asset.)

Moving forward with asset creation, if the Asset model selected requires a serial, a form validation will fire:
image

Require Serial Number is also a sortable field in the Asset Models index:
image

Tests have been included.

@Godmartinz Godmartinz marked this pull request as ready for review May 19, 2025 17:08
@Godmartinz Godmartinz requested a review from snipe as a code owner May 19, 2025 17:08
@Godmartinz Godmartinz requested a review from marcusmoore May 19, 2025 17:08
@Godmartinz Godmartinz changed the title WIP: Adds require serial as Asset Model option Adds require serial as Asset Model option May 19, 2025
Copy link
Member

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably have a few things to talk about in there, but this is very clean code, very well-executed. Let's chat more offline and see if we want to embed in other stuff or take this as-is.

@Godmartinz
Copy link
Member Author

before this gets merged, let me know if you would like me to make any changes 👍

@viclou
Copy link
Member

viclou commented Jun 17, 2025

Any movement on this? [FD48448]

@snipe
Copy link
Member

snipe commented Jun 18, 2025

@viclou if there was, you’d have seen it here.

Copy link
Member

@snipe snipe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a requiredness indicator on the serial number in those screenshots.

@DECStudioHub
Copy link

Enhancement Request: Improved Asset Tracking - Unique Serial Numbers or Customizable Forms

Team,

To prevent duplicate asset entries and improve inventory management, we propose two solutions:

Enforce Unique Serial Numbers: Implementing a system constraint to ensure unique serial numbers would prevent duplicate entries and significantly improve data accuracy. This is particularly important when assets share the same asset tag but have distinct serial numbers.

Customizable Forms with Conditional Serial Fields: Alternatively, providing customizable forms with the ability to show or hide the serial number field would offer flexibility. We have already implemented a workaround using custom fields to prevent duplicate serials, but a built-in solution would be more efficient and user-friendly.

We request that you consider incorporating either of these enhancements in a future update. This will greatly improve the accuracy and flexibility of our asset tracking.

Thank you for your consideration.

image

image

@snipe
Copy link
Member

snipe commented Jun 27, 2025

@DECStudioHub - this PR is the solution. It's just still in testing.

@snipe
Copy link
Member

snipe commented Jul 7, 2025

@Godmartinz did we get the requiredness indicator handled?

@Godmartinz
Copy link
Member Author

indicator is there now:
image

@Godmartinz Godmartinz requested a review from snipe July 7, 2025 17:47
@viclou
Copy link
Member

viclou commented Jul 19, 2025

[FD-48448]

@snipe snipe merged commit 739980a into grokability:develop Sep 3, 2025
6 of 7 checks passed
@DECStudioHub
Copy link

DECStudioHub commented Sep 4, 2025

Serial is Unique?? I Need The Serial Is Unique Value To Prevent Duplication of Devices

indicator is there now:
image

@snipe
Copy link
Member

snipe commented Sep 4, 2025

@DECStudioHub If you select that on the model, yes, per the original PR summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants