Fix Content-Type Header not being set correctly for testWebhook #18151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Godmartinz Can you confirm this won't break any of the other integrations? |
Godmartinz
approved these changes
Nov 4, 2025
Member
Godmartinz
left a comment
Godmartinz
left a comment
There was a problem hiding this comment.
webhook tests works, good catch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Content-Typeheader was not being set correctly in the fix for #15946. Theheaderskey should not be in an array in theoptionsarray; it should be a key of theoptionsarray itself.I am not sure if Slack was rejecting this as well, but I noticed it while setting up a Discord webhook.