Override unique_undeleted in the form request #18155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcusmoore
approved these changes
Nov 4, 2025
Collaborator
marcusmoore
left a comment
marcusmoore
left a comment
There was a problem hiding this comment.
I haven't pulled this down to test it but we're doing the same for asset_tag and I think this approach works (at least for now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure where this broke, but it looks like the UniqueUndeletedTrait isn't actually being invoked here, at least not on a PATCH update via the API, so it wasn't seeing its own ID, causing an erroneous "The serial must be unique" validation error when updating the original asset in the API.
This is a stab at correcting that to fix #18021