Fixes FD51910 requestable asset model available quantity count #18192
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snipe
reviewed
Nov 13, 2025
| 'category', | ||
| 'requests', | ||
| 'assets' => function ($q) { | ||
| $q->where('requestable', 1) |
Member
There was a problem hiding this comment.
We could probably just use our existing query scopes here btw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the asset model query to search for only deployable or pending and excludes archived assets. Assets have to be requestable as well.
Before under Asset Models:
After:
The count for macbook pros in this case under assets is the same now:
Fixes FD51910