Skip to content

Fixed #18189 - added option to pick the day the week starts on #18195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2025
+71 −1
Merged

Fixed #18189 - added option to pick the day the week starts on #18195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
308cd6b
Fixed #18189 - added option to pick the day the week starts on
snipe Nov 13, 2025
6b9d494
Language tweaks
snipe Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/Http/Controllers/SettingsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -589,6 +589,7 @@ public function postLocalization(StoreLocalizationSettings $request) : RedirectR
$setting->time_display_format = $request->input('time_display_format');
$setting->digit_separator = $request->input('digit_separator');
$setting->name_display_format = $request->input('name_display_format');
$setting->week_start = $request->input('week_start', 0);

if ($setting->save()) {
return redirect()->route('settings.index')
Expand Down
30 changes: 30 additions & 0 deletions database/migrations/2025_11_13_160816_add_day_of_week_setting.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
<?php

use Illuminate\Database\Migrations\Migration;
use Illuminate\Database\Schema\Blueprint;
use Illuminate\Support\Facades\Schema;

return new class extends Migration
{
/**
* Run the migrations.
*/
public function up(): void
{
Schema::table('settings', function (Blueprint $table) {
$table->tinyInteger('week_start')->after('locale')->nullable()->default(0);
});
}

/**
* Reverse the migrations.
*/
public function down(): void
{
Schema::table('settings', function (Blueprint $table) {
if (Schema::hasColumn('settings', 'week_start')) {
$table->dropColumn('week_start');
}
});
}
};
2 changes: 2 additions & 0 deletions resources/lang/en-US/datepicker.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@
|
*/

'week_start_select' => 'Select Day of Week',
'week_start' => 'Day the Week Starts On',
'today' => 'Today',
'clear' => 'Clear',
'days' => [
Expand Down
2 changes: 1 addition & 1 deletion resources/views/layouts/default.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1145,7 +1145,7 @@
today: "{{ trans('datepicker.today') }}",
clear: "{{ trans('datepicker.clear') }}",
format: "yyyy-mm-dd",
weekStart: 0
weekStart: {{ $snipeSettings->week_start ?? 0 }},
};

var clipboard = new ClipboardJS('.js-copy-link');
Expand Down
37 changes: 37 additions & 0 deletions resources/views/settings/localization.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,43 @@

</div>

<!-- Week Start format -->
<div class="form-group {{ $errors->has('week_start') ? 'error' : '' }}">

<label for="week_start" class="col-md-3 control-label">{{ trans('datepicker.week_start') }}</label>

<div class="col-md-5 col-xs-12">
<select name="week_start" class="select2" style="width: 100%;" aria-label="week_start" data-placeholder="{{ trans('datepicker.select_day') }}">
<option value="0" @selected(old('week_start', $setting->week_start) == 0)>
{{ trans('datepicker.days.sunday') }}
</option>
<option value="1" @selected(old('week_start', $setting->week_start) == 1)>
{{ trans('datepicker.days.monday') }}
</option>
<option value="2" @selected(old('week_start', $setting->week_start) == 2)>
{{ trans('datepicker.days.tuesday') }}
</option>
<option value="3" @selected(old('week_start', $setting->week_start) == 3)>
{{ trans('datepicker.days.wednesday') }}
</option>
<option value="4" @selected(old('week_start', $setting->week_start) == 4)>
{{ trans('datepicker.days.thursday') }}
</option>
<option value="5" @selected(old('week_start', $setting->week_start) == 5)>
{{ trans('datepicker.days.friday') }}
</option>
<option value="6" @selected(old('week_start', $setting->week_start) == 6)>
{{ trans('datepicker.days.saturday') }}
</option>

</select>

</div>

{!! $errors->first('week_start', '<div class="col-md-9 col-md-offset-3"><span class="alert-msg" aria-hidden="true">:message</span> </div>') !!}

</div>

<!-- Currency -->
<div class="form-group {{ $errors->has('default_currency') ? 'error' : '' }}">

Expand Down
Loading