Fixes inaccurate monthly depreciation value displayed at depreciation report when using a floor value #18248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there! So apparently, I'm laying my hands on the code around reporting and stumbled upon this bug.
And.. yes, I have tested this on the demo website, and it appears to still be there :0
Here, I would give the exact steps (preconditions) on how I reproduce the bug, and also my proposed solution.
Feel free to adjust if it's not quite well!
Thanks!
Preconditions 📝
Bug 🐛
On Depreciation Report page, it displayed an inaccurate value for Monthly Depreciation as

DepreciationReportTransformerignores the floor value!*based from Straight-line Depreciation calculation
Proposed Solution 💡
Utilize defined formula at parent class
app\Models\Depreciable.phpFixed Result ✅