Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions app/Http/Controllers/Api/ProfileController.php
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use Illuminate\Contracts\Validation\Factory as ValidationFactory;
use Illuminate\Support\Facades\Gate;
use App\Models\CustomField;
use App\Models\User;
use Illuminate\Support\Facades\DB;
use Illuminate\Http\JsonResponse;
use Symfony\Component\HttpFoundation\BinaryFileResponse;
Expand Down Expand Up @@ -179,10 +180,17 @@ public function showApiTokens() : JsonResponse
*@since [v8.1.16]
* @author [Godfrey Martinez] [<[email protected]>]
*/
public function eulas(ProfileTransformer $transformer)
public function eulas(ProfileTransformer $transformer, Request $request)
{
// Only return this user's EULAs
$eulas = auth()->user()->eulas;
if($request->filled('user_id') && $request->input('user_id') != 0) {
// Return selected user's EULAs
$eulas = User::find($request->input('user_id'))->eulas;
}
else {
// Only return this user's EULAs
$eulas = auth()->user()->eulas;
}

return response()->json(
$transformer->transformFiles($eulas, $eulas->count())
);
Expand Down
6 changes: 5 additions & 1 deletion app/Http/Controllers/ProfileController.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use App\Http\Requests\ImageUploadRequest;
use App\Http\Transformers\ProfileTransformer;
use App\Models\Actionlog;
use App\Models\Asset;
use App\Models\Setting;
use App\Models\User;
use App\Notifications\CurrentInventory;
Expand Down Expand Up @@ -249,7 +250,10 @@ public function getStoredEula($filename) : Response | BinaryFileResponse | Redir
$logentry = Actionlog::where('filename', $filename)->first();

// Make sure the user has permission to view this file
if (auth()->id() != $logentry->target_id) {
// Also allow if the user (manager) able to view both users and assets
$allowed_to_view_users_assets = Gate::allows('view', User::class) && Gate::allows('view', Asset::class);

if (auth()->id() != $logentry->target_id && !$allowed_to_view_users_assets) {
return redirect()->route('account')->with('error', trans('general.generic_model_not_found', ['model' => 'file']));
}

Expand Down
2 changes: 1 addition & 1 deletion resources/views/account/view-assets.blade.php
Original file line number Diff line number Diff line change
Expand Up @@ -759,7 +759,7 @@ class="table table-striped snipe-table table-hover"
data-sort-order="asc"
data-sort-name="name"
class="table table-striped snipe-table table-hover"
data-url="{{ route('api.self.eulas') }}"
data-url="{{ route('api.self.eulas', ['user_id' => e(request('user_id'))]) }}"
data-export-options='{
"fileName": "export-eula-{{ str_slug($user->username) }}-{{ date('Y-m-d') }}",
"ignoreColumn": ["actions","image","change","checkbox","checkincheckout","delete","purchasecost", "icon"]
Expand Down