-
Notifications
You must be signed in to change notification settings - Fork 2
Adding del() to remove map entries (e.g del(x[y])) or variables; optimize small map Set #302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…hanks to optimization in small map get
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
eval/eval.go:441
- [nitpick] Consider providing a clearer and more descriptive error message for the DOT case in delete, or implement the expected behavior instead of using a TODO message.
return s.NewError("TODO remove map dot:" + index.Inspect())
token/type_string.go:88
- [nitpick] Verify that the updated _Type_name constant and index mapping correctly reflect the intended token order, ensuring the DEL token is appropriately positioned relative to others.
const _Type_name = "ILLEGALEOLstartValueTokensIDENTINTFLOATSTRINGLINECOMMENTBLOCKCOMMENTREGISTERendValueTokensstartSingleCharTokensASSIGNPLUSMINUSBANGASTERISKSLASHPERCENTLTGTBITANDBITORBITXORBITNOTCOMMASEMICOLONLPARENRPARENLBRACERBRACELBRACKETRBRACKETCOLONDOTendSingleCharTokensstartMultiCharTokensLTEQGTEQEQNOTEQINCRDECRDOTDOTORANDLEFTSHIFTRIGHTSHIFTLAMBDADEFINEendMultiCharTokensstartIdentityTokensFUNCTRUEFALSEIFELSERETURNFORBREAKCONTINUEMACROQUOTEUNQUOTELENFIRSTRESTPRINTPRINTLNLOGERRORCATCHDELendIdentityTokensEOF"
object/object.go:379
- [nitpick] Review the transition code in SmallMap Set: confirm that using m.smallKV[i:m.len-1] correctly captures all elements after the insertion index when converting to a BigMap.
res := &BigMap{kv: make([]keyValuePair, 0, m.len)}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Fixes #291 (and more)