-
Notifications
You must be signed in to change notification settings - Fork 25
Chromatic QA -- DRAFT #5262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Chromatic QA -- DRAFT #5262
Conversation
|
✅ Deploy Preview for hpe-theme-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for unrivaled-bublanina-3a9bae ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Storybook: https://deploy-preview-5262--unrivaled-bublanina-3a9bae.netlify.app/
Chromatic: https://www.chromatic.com/build?appId=68a37e6158d976c56631627e&number=10
What does this PR do?
QA for the new theme using chromatic snapshots on the existing storybook stories in this repo.
I went through and re-mapped the t-shirt sizes. I am getting 15 snapshots that are different than the baseline snapshots.
Where should the reviewer start?
What testing has been done on this PR?
In addition to the feature you are implementing, have you checked the following:
General UX Checks
Accessibility Checks
Code Quality Checks
How should this be manually tested?
Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?