Skip to content

Conversation

@jcfilben
Copy link
Collaborator

@jcfilben jcfilben commented Aug 20, 2025

Storybook: https://deploy-preview-5262--unrivaled-bublanina-3a9bae.netlify.app/
Chromatic: https://www.chromatic.com/build?appId=68a37e6158d976c56631627e&number=10

What does this PR do?

QA for the new theme using chromatic snapshots on the existing storybook stories in this repo.
I went through and re-mapped the t-shirt sizes. I am getting 15 snapshots that are different than the baseline snapshots.

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

@changeset-bot
Copy link

changeset-bot bot commented Aug 20, 2025

⚠️ No Changeset found

Latest commit: 4c00114

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Aug 20, 2025

Deploy Preview for hpe-theme-preview ready!

Name Link
🔨 Latest commit 4c00114
🔍 Latest deploy log https://app.netlify.com/projects/hpe-theme-preview/deploys/68af2afcaf270c000876405f
😎 Deploy Preview https://deploy-preview-5262--hpe-theme-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Aug 20, 2025

Deploy Preview for unrivaled-bublanina-3a9bae ready!

Name Link
🔨 Latest commit 4c00114
🔍 Latest deploy log https://app.netlify.com/projects/unrivaled-bublanina-3a9bae/deploys/68af2afc7b919c00082a591f
😎 Deploy Preview https://deploy-preview-5262--unrivaled-bublanina-3a9bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jcfilben jcfilben marked this pull request as draft August 20, 2025 19:16
@britt6612 britt6612 mentioned this pull request Aug 28, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants