Skip to content

Conversation

@Sulaymon333
Copy link
Collaborator

@Sulaymon333 Sulaymon333 commented Sep 17, 2025

Deploy Preview

What does this PR do?

  • update grommet-theme-hpe to v7 for sandbox/grommet-app
    • sandbox/grommet-app/src/components grommet theme hpe codemod migration v6 - v7
    • sandbox/grommet-app/src/pages grommet theme hpe codemod migration v6 - v7
    • sandbox/grommet-app/src/Login.jsx grommet theme hpe codemod migration v6 - v7
  • closes Upgrade sandbox/grommet-app to use v7 of hpe theme #5327

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

@changeset-bot
Copy link

changeset-bot bot commented Sep 17, 2025

⚠️ No Changeset found

Latest commit: 6f97d72

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Sep 17, 2025

Deploy Preview for unrivaled-bublanina-3a9bae ready!

Name Link
🔨 Latest commit 6c8b70c
🔍 Latest deploy log https://app.netlify.com/projects/unrivaled-bublanina-3a9bae/deploys/68cdc8e9435c29000826078b
😎 Deploy Preview https://deploy-preview-5333--unrivaled-bublanina-3a9bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Sep 17, 2025

Deploy Preview for hpe-theme-preview ready!

Name Link
🔨 Latest commit 6c8b70c
🔍 Latest deploy log https://app.netlify.com/projects/hpe-theme-preview/deploys/68cdc8e9a98c5200085a7e7d
😎 Deploy Preview https://deploy-preview-5333--hpe-theme-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Sulaymon333 Sulaymon333 changed the title update grommet-theme-hpe to v7 for sandbox/grommet-app [UPDATE] grommet-theme-hpe to v7 for sandbox/grommet-app Sep 17, 2025
@Sulaymon333
Copy link
Collaborator Author

I noticed a small layout shift which seems to be resolved after running codemod LOCALLY with a very subtle height difference in the last card. See attached screenshots below for more details.

Before running codemod locally
image

After running codemod locally
image

Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect us to need to re-map the t-shirt sizes. For the sticker sheet can we set it up to compare v6 theme to v7 (previously it was comparing v5 to v6)?

@Sulaymon333
Copy link
Collaborator Author

Sulaymon333 commented Sep 24, 2025

Sticker sheet looks OK to me after re-mapping to update tshirt sizes. But main page graphs are not in place for v0 theme (grommet theme hpe v6). See below.

image

V1 (grommet theme hpe v7) looks Ok
image

Sticker sheet looks OK on both versions of the theme
image

image

@Sulaymon333 Sulaymon333 changed the base branch from master to site-theme-v7 September 25, 2025 14:51
@Sulaymon333
Copy link
Collaborator Author

The v5 theme issue layout shift is now fixed.

image image

@britt6612 britt6612 changed the base branch from site-theme-v7 to master October 2, 2025 19:31
@Sulaymon333 Sulaymon333 self-assigned this Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade sandbox/grommet-app to use v7 of hpe theme

4 participants