-
Notifications
You must be signed in to change notification settings - Fork 25
[FIX] Page abstract image #5391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* update grommet-theme-hpe and tshirt sizing for aries-core * update eslint filed --------- Co-authored-by: sulaymon-tajudeen-hpe <[email protected]>
Co-authored-by: sulaymon-tajudeen-hpe <[email protected]>
Co-authored-by: sulaymon-tajudeen-hpe <[email protected]>
Co-authored-by: sulaymon-tajudeen-hpe <[email protected]>
…ValueListEditExample.js
…onents/NameValueListFormField.js
…ValueListEditExample.js
…onents/NameValueListFormField.js
[UPDATE] aries-site-4 tshirt sizes for listed files
Co-authored-by: sulaymon-tajudeen-hpe <[email protected]>
* update tshirt sizes for listed files * Update aries-site/src/examples/learn/how-to/how-to-add-additional-controls-to-a-toolbar/Completed.js * Update aries-site/src/examples/learn/how-to/how-to-add-additional-controls-to-a-toolbar/Completed.js --------- Co-authored-by: sulaymon-tajudeen-hpe <[email protected]> Co-authored-by: Jessica Rosenquist <[email protected]>
Co-authored-by: sulaymon-tajudeen-hpe <[email protected]>
* update tshirt sizes for listed files * Update aries-site/src/examples/templates/content-layouts/ResponsiveContentLayoutExample.js * Update aries-site/src/examples/templates/content-layouts/ResponsiveContentLayoutExample.js * Update aries-site/src/examples/templates/dashboards/ThreeColumnDashboard.js * Update aries-site/src/examples/templates/dashboards/TwoColumnDashboard.js * Update aries-site/src/examples/templates/dashboards/TwoColumnDashboard.js --------- Co-authored-by: sulaymon-tajudeen-hpe <[email protected]> Co-authored-by: Jessica Rosenquist <[email protected]>
* update tshirt sizes for listed files * Update aries-site/src/examples/templates/global-banner-notifications/BannerContentLayoutExample.js * Update aries-site/src/examples/templates/global-banner-notifications/BannerContentLayoutExample.js * Apply suggestions from code review --------- Co-authored-by: sulaymon-tajudeen-hpe <[email protected]> Co-authored-by: Jessica Rosenquist <[email protected]>
[UPDATE] aries-site-10 tshirt sizes for listed files
Co-authored-by: Jessica Rosenquist <[email protected]>
Transform mdx files
|
|
@oliverHPE do we need to update the image below as well?
|
|
@oliverHPE @halocline @jcfilben On the topic of background again, are we supposed to update the background we provide from the theme as well with new brand asset background?
some examples of backgrounds provided by the theme are shown below
|
|
Lets connect with @oliverHPE since were in this file and change the image for this as well
|
@Sulaymon333 can you follow up here as well |
britt6612
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets get a direction on the other image as well as the other background if we need to update
background={{
fill: 'horizontal',
color: '#FFFFFF', // ensure correct font color and contrast
image: `linear-gradient(
0deg,
#FFFFFF 0%,
#D8CFF7 55%,
#B098F0 80%,
#7630EA 100%
)`,
}}
|
the attached imaged above are not visible. Please can you re-upload? |
|
@oliverHPE has to hold off on this for now as discussed offline. |
|
@oliverHPE do you have some updates on this? |








Deploy Preview
What does this PR do?
components/pageabstract image with new asset from brand refresh.Where should the reviewer start?
What testing has been done on this PR?
In addition to the feature you are implementing, have you checked the following:
General UX Checks
Accessibility Checks
Code Quality Checks
How should this be manually tested?
Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?