Skip to content

Conversation

@Sulaymon333
Copy link
Collaborator

Deploy Preview

What does this PR do?

  • replace components/page abstract image with new asset from brand refresh.

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

sulaymon-tajudeen-hpe and others added 30 commits September 23, 2025 22:03
* update grommet-theme-hpe and tshirt sizing for aries-core

* update eslint filed

---------

Co-authored-by: sulaymon-tajudeen-hpe <[email protected]>
[UPDATE] aries-site-4 tshirt sizes for listed files
* update tshirt sizes for listed files

* Update aries-site/src/examples/learn/how-to/how-to-add-additional-controls-to-a-toolbar/Completed.js

* Update aries-site/src/examples/learn/how-to/how-to-add-additional-controls-to-a-toolbar/Completed.js

---------

Co-authored-by: sulaymon-tajudeen-hpe <[email protected]>
Co-authored-by: Jessica Rosenquist <[email protected]>
* update tshirt sizes for listed files

* Update aries-site/src/examples/templates/content-layouts/ResponsiveContentLayoutExample.js

* Update aries-site/src/examples/templates/content-layouts/ResponsiveContentLayoutExample.js

* Update aries-site/src/examples/templates/dashboards/ThreeColumnDashboard.js

* Update aries-site/src/examples/templates/dashboards/TwoColumnDashboard.js

* Update aries-site/src/examples/templates/dashboards/TwoColumnDashboard.js

---------

Co-authored-by: sulaymon-tajudeen-hpe <[email protected]>
Co-authored-by: Jessica Rosenquist <[email protected]>
* update tshirt sizes for listed files

* Update aries-site/src/examples/templates/global-banner-notifications/BannerContentLayoutExample.js

* Update aries-site/src/examples/templates/global-banner-notifications/BannerContentLayoutExample.js

* Apply suggestions from code review

---------

Co-authored-by: sulaymon-tajudeen-hpe <[email protected]>
Co-authored-by: Jessica Rosenquist <[email protected]>
[UPDATE] aries-site-10 tshirt sizes for listed files
@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2025

⚠️ No Changeset found

Latest commit: 7b89d88

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Sulaymon333
Copy link
Collaborator Author

Sulaymon333 commented Oct 10, 2025

@oliverHPE do we need to update the image below as well?

image

@Sulaymon333
Copy link
Collaborator Author

Sulaymon333 commented Oct 10, 2025

@oliverHPE @halocline @jcfilben

On the topic of background again, are we supposed to update the background we provide from the theme as well with new brand asset background?

image

some examples of backgrounds provided by the theme are shown below

image image

@britt6612
Copy link
Collaborator

Lets connect with @oliverHPE since were in this file and change the image for this as well

Screenshot 2025-10-14 at 4 18 41 PM

@britt6612
Copy link
Collaborator

@oliverHPE @halocline @jcfilben

On the topic of background again, are we supposed to update the background we provide from the theme as well with new brand asset background?

image some examples of backgrounds provided by the theme are shown below

image image

@Sulaymon333 can you follow up here as well

Copy link
Collaborator

@britt6612 britt6612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets get a direction on the other image as well as the other background if we need to update

      background={{
        fill: 'horizontal',
        color: '#FFFFFF', // ensure correct font color and contrast
        image: `linear-gradient(
          0deg, 
          #FFFFFF 0%,
          #D8CFF7 55%,
          #B098F0 80%,
          #7630EA 100%
        )`,
      }}

@Sulaymon333
Copy link
Collaborator Author

the attached imaged above are not visible. Please can you re-upload?

@britt6612
Copy link
Collaborator

the attached imaged above are not visible. Please can you re-upload?

not sure I understand? this image is still in the example
Screenshot 2025-10-14 at 4 18 41 PM

@Sulaymon333
Copy link
Collaborator Author

@oliverHPE has to hold off on this for now as discussed offline.

@Sulaymon333 Sulaymon333 self-assigned this Oct 21, 2025
@Sulaymon333
Copy link
Collaborator Author

@oliverHPE do you have some updates on this?

Base automatically changed from v8-theme-QA to master October 30, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants