-
Notifications
You must be signed in to change notification settings - Fork 25
[REMOVE] static image and point it to code and improve text #5402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
* update grommet-theme-hpe and tshirt sizing for aries-core * update eslint filed --------- Co-authored-by: sulaymon-tajudeen-hpe <[email protected]>
Co-authored-by: sulaymon-tajudeen-hpe <[email protected]>
Co-authored-by: sulaymon-tajudeen-hpe <[email protected]>
Co-authored-by: sulaymon-tajudeen-hpe <[email protected]>
…ValueListEditExample.js
…onents/NameValueListFormField.js
…ValueListEditExample.js
…onents/NameValueListFormField.js
[UPDATE] aries-site-4 tshirt sizes for listed files
Co-authored-by: sulaymon-tajudeen-hpe <[email protected]>
* update tshirt sizes for listed files * Update aries-site/src/examples/learn/how-to/how-to-add-additional-controls-to-a-toolbar/Completed.js * Update aries-site/src/examples/learn/how-to/how-to-add-additional-controls-to-a-toolbar/Completed.js --------- Co-authored-by: sulaymon-tajudeen-hpe <[email protected]> Co-authored-by: Jessica Rosenquist <[email protected]>
Co-authored-by: sulaymon-tajudeen-hpe <[email protected]>
* update tshirt sizes for listed files * Update aries-site/src/examples/templates/content-layouts/ResponsiveContentLayoutExample.js * Update aries-site/src/examples/templates/content-layouts/ResponsiveContentLayoutExample.js * Update aries-site/src/examples/templates/dashboards/ThreeColumnDashboard.js * Update aries-site/src/examples/templates/dashboards/TwoColumnDashboard.js * Update aries-site/src/examples/templates/dashboards/TwoColumnDashboard.js --------- Co-authored-by: sulaymon-tajudeen-hpe <[email protected]> Co-authored-by: Jessica Rosenquist <[email protected]>
* update tshirt sizes for listed files * Update aries-site/src/examples/templates/global-banner-notifications/BannerContentLayoutExample.js * Update aries-site/src/examples/templates/global-banner-notifications/BannerContentLayoutExample.js * Apply suggestions from code review --------- Co-authored-by: sulaymon-tajudeen-hpe <[email protected]> Co-authored-by: Jessica Rosenquist <[email protected]>
[UPDATE] aries-site-10 tshirt sizes for listed files
Co-authored-by: Jessica Rosenquist <[email protected]>
Transform mdx files
[Fix] menu missing items
|
# Please enter a commit message to explain why this merge is necessary,
|
Pausing on review since this item isn't a blocking fix for the site upgrade (blocking fixes indicated by the red dot in figma) https://www.figma.com/board/wu0mKoWFNKqG2xsLT1m5Po/Docs-site-QA?node-id=0-1&p=f&t=oBIalNZUvaFnN7lW-0 |
|
@jcfilben, @britt6612 can yoiu have a second pass on this PR? Thank you. |
See above comment |
Deploy Preview
What does this PR do?
Where should the reviewer start?
What testing has been done on this PR?
In addition to the feature you are implementing, have you checked the following:
General UX Checks
Accessibility Checks
Code Quality Checks
How should this be manually tested?
Any background context you want to provide?
What are the relevant issues?
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Is this change backwards compatible or is it a breaking change?