Skip to content

Conversation

@Sulaymon333
Copy link
Collaborator

Deploy Preview

What does this PR do?

  • remove static image and point it to code and improve text

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

sulaymon-tajudeen-hpe and others added 30 commits September 23, 2025 22:03
* update grommet-theme-hpe and tshirt sizing for aries-core

* update eslint filed

---------

Co-authored-by: sulaymon-tajudeen-hpe <[email protected]>
[UPDATE] aries-site-4 tshirt sizes for listed files
* update tshirt sizes for listed files

* Update aries-site/src/examples/learn/how-to/how-to-add-additional-controls-to-a-toolbar/Completed.js

* Update aries-site/src/examples/learn/how-to/how-to-add-additional-controls-to-a-toolbar/Completed.js

---------

Co-authored-by: sulaymon-tajudeen-hpe <[email protected]>
Co-authored-by: Jessica Rosenquist <[email protected]>
* update tshirt sizes for listed files

* Update aries-site/src/examples/templates/content-layouts/ResponsiveContentLayoutExample.js

* Update aries-site/src/examples/templates/content-layouts/ResponsiveContentLayoutExample.js

* Update aries-site/src/examples/templates/dashboards/ThreeColumnDashboard.js

* Update aries-site/src/examples/templates/dashboards/TwoColumnDashboard.js

* Update aries-site/src/examples/templates/dashboards/TwoColumnDashboard.js

---------

Co-authored-by: sulaymon-tajudeen-hpe <[email protected]>
Co-authored-by: Jessica Rosenquist <[email protected]>
* update tshirt sizes for listed files

* Update aries-site/src/examples/templates/global-banner-notifications/BannerContentLayoutExample.js

* Update aries-site/src/examples/templates/global-banner-notifications/BannerContentLayoutExample.js

* Apply suggestions from code review

---------

Co-authored-by: sulaymon-tajudeen-hpe <[email protected]>
Co-authored-by: Jessica Rosenquist <[email protected]>
[UPDATE] aries-site-10 tshirt sizes for listed files
@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2025

⚠️ No Changeset found

Latest commit: 7efc0c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Sulaymon333 Sulaymon333 self-assigned this Oct 21, 2025
@jcfilben
Copy link
Collaborator

Pausing on review since this item isn't a blocking fix for the site upgrade (blocking fixes indicated by the red dot in figma) https://www.figma.com/board/wu0mKoWFNKqG2xsLT1m5Po/Docs-site-QA?node-id=0-1&p=f&t=oBIalNZUvaFnN7lW-0

@Sulaymon333
Copy link
Collaborator Author

@jcfilben, @britt6612 can yoiu have a second pass on this PR? Thank you.

@jcfilben
Copy link
Collaborator

@jcfilben, @britt6612 can yoiu have a second pass on this PR? Thank you.

See above comment

Base automatically changed from v8-theme-QA to master October 30, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants