[HPE Icons] Library – Added Element icon #5578
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added element icon, updated index files and metadata. Added new SVG data for DocumentUpload having identified an issue with the rounded corner on the arrow.
|
❌ Deploy Preview for hpe-theme-preview failed. Why did it fail? →
|
✅ Deploy Preview for hpe-design-icons-grommet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
❌ Deploy Preview for unrivaled-bublanina-3a9bae failed. Why did it fail? →
|
jcfilben
reviewed
Nov 21, 2025
Collaborator
jcfilben
left a comment
jcfilben
left a comment
There was a problem hiding this comment.
I think we will also need to update the svg files in packages/icons/core/src/icons
New element.svg icon Updated document-upload.svg
Collaborator
Author
@jcfilben I've pushed those changes. https://github.com/grommet/hpe-design-system/pull/5578/files |
9 tasks
jcfilben
reviewed
Nov 24, 2025
| <svg width="24" height="24" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
| <path d="M7.86914 11.2246C8.26191 10.9043 8.84092 10.9269 9.20703 11.293L11.707 13.793L10.293 15.207L9.5 14.4141V18H7.5V14.4141L6.70703 15.207C6.31651 15.5976 5.68349 15.5976 5.29297 15.207C4.90244 14.8165 4.90244 14.1835 5.29297 13.793L7.79297 11.293L7.86914 11.2246Z" fill="currentColor"/> | ||
| <path fill-rule="evenodd" clip-rule="evenodd" d="M13.5205 1C14.714 1.00005 15.8682 1.42739 16.7744 2.2041L21.2539 6.04395C22.362 6.99385 23 8.38031 23 9.83984V18C23 20.7614 20.7614 23 18 23H6C3.23858 23 1 20.7614 1 18V6C1 3.23858 3.23858 1 6 1H13.5205ZM6 3C4.34315 3 3 4.34315 3 6V18C3 19.6569 4.34315 21 6 21H18C19.6569 21 21 19.6569 21 18V10H16C14.3431 10 13 8.65685 13 7V3H6ZM15 7C15 7.55228 15.4477 8 16 8H20.3682C20.2453 7.8419 20.1067 7.69403 19.9521 7.56152L15.4727 3.72266C15.3254 3.59641 15.1666 3.48613 15 3.3916V7Z" fill="currentColor"/> | ||
| <path d="M1 18V6C1 3.23858 3.23858 1 6 1H13.5205C14.714 1.00005 15.8682 1.42739 16.7744 2.2041L21.2539 6.04297C22.3621 6.99288 23 8.38022 23 9.83984V18C23 20.7614 20.7614 23 18 23H6C3.23858 23 1 20.7614 1 18ZM7.5 18V14.4141L6.70703 15.207C6.31651 15.5976 5.68349 15.5976 5.29297 15.207C4.90244 14.8165 4.90244 14.1835 5.29297 13.793L7.79297 11.293L7.86914 11.2246C8.26191 10.9043 8.84092 10.9269 9.20703 11.293L11.707 13.793C12.0976 14.1835 12.0976 14.8165 11.707 15.207C11.3165 15.5976 10.6835 15.5976 10.293 15.207L9.5 14.4141V18C9.5 18.5523 9.05229 19 8.5 19C7.94772 19 7.5 18.5523 7.5 18ZM15 7C15 7.55228 15.4477 8 16 8H20.3682C20.2453 7.8419 20.1067 7.69403 19.9521 7.56152L15.4727 3.72266C15.3254 3.59641 15.1666 3.48613 15 3.3916V7ZM3 18C3 19.6569 4.34315 21 6 21H18C19.6569 21 21 19.6569 21 18V10H16C14.3431 10 13 8.65685 13 7V3H6C4.34315 3 3 4.34315 3 6V18Z" fill="#3E4550"/> |
Collaborator
There was a problem hiding this comment.
I think fill should be "currentColor"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added element icon, updated index files and metadata.
Added new SVG data for DocumentUpload having identified an issue with the rounded corner on the arrow.
Note the element uses the exact code from the Grommet repo, which only a modification to use the updated brand green (in hex)
Element
https://deploy-preview-5578--hpe-design-icons-grommet.netlify.app/?path=/story/icons-hpe-icons-for-grommet--default&args=iconName:Element;size:xxlarge
DocumentUpload
https://deploy-preview-5578--hpe-design-icons-grommet.netlify.app/?path=/story/icons-hpe-icons-for-grommet--default&args=iconName:DocumentUpload;size:xxlarge
Deploy Preview
What does this PR do?
What are the relevant issues?
Where should the reviewer start?
Storybook look for inclusion Element
Look for visual update of DocumentUpload
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
No but followup to task for icon migration guide and code mod noting that the icon name has been remapped.
Hpe ----> Element
Is this change backwards compatible or is it a breaking change?
Change backwards