tools: GEODESICSTRING n≥2 maps to the LineString MkChord bag - #745
Merged
Merged
Conversation
WktIntakeWalker now mirrors LINESTRING for GEODESICSTRING (same lineStringText shape): empty and singleton stay named Declines; n>=2 is mapLineString / MkChord. Compound-curve geodesic members visit the same mapper. SPIRALCURVE stays Decline. Coherence with open PR #744 μ (TGeodesicString → map_ls). No Rocq in this letter. This PR was drafted with AI assistance. Co-authored-by: Jeroen Bloemscheer <grootstebozewolf@users.noreply.github.com>
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
claimId: none
WITNESS: none
topics: overlay
board: ADR-0007 — tools visitor coherence with open PR #744 (
0007-intake-geodesic)branched from:
main@4f0ea62tip:
8deea44This PR was drafted with AI assistance.
What this letter IS
Tools-only.
tools/WktIntakeWalkernow accepts well-formedGEODESICSTRING(n≥2) by mapping it onto the same LineString /MkChordbag path that Rocq μ already proves forTGeodesicStringon #744.visitGeodesicStringGeometrymirrorsLINESTRING(GEODESICSTRING dim? lineStringText):Z/M/ZM→ID_NotFirstSlice; otherwisemapLineString(pointsOf(lineStringText)).ID_Empty. Singleton →ID_BadPointCount.n≥2→BAG hens=… chickens=…:MkChord.visitCurveMembervisits a geodesic member instead of hard-decliningID_GeodesicString. Spiral member staysID_SpiralCurve.ID_GeodesicStringstays on the Reason enum (unused is fine)..g4) is unchanged. No new keyword, no WKB 13, no ellipsoid γ, noMkGeodesic.Locked smoke row:
GEODESICSTRING (0 0, 2 0)produces the same bag asLINESTRING (0 0, 2 0):BAG hens=0,1 pts=0 0;2 0 chickens=0-1:MkChordWhat this letter is NOT
theories/change. μ forTGeodesicStringlives on letter: GeodesicString as sheet geodesic (claimId 0007-intake-geodesic) #744; this PR does not remint0007-intake-geodesic.MkGeodesic/geodesic_eval/ WKB 13 / ellipsoid γ / a second Rocq letter.SPIRALCURVEfold-in. Spiral stays named Decline.Proof surface
Java visitor only. Same mapping table as #744 μ (
intake_map S (TGeodesicString pts)→IntakeBag (map_ls S pts)forn≥2). Engines later test the bag, not the string.Smoke / CI
bash tools/WktIntakeWalker/smoke.shgreen on8deea44(locked geodesic bag, EMPTY, singleton, compound-curve geodesic member, spiral still Decline).make ci-guardsgreen locally (1723 cited theorems).build proofsgreen on8deea44: Corpus guardrails, Build with Rocq 9.2.0, Build theories-flocq in pinned container.Do not merge.