WKT: name SQL/MM §4.2.1 curve types and refuse - #21
Merged
Merged
Conversation
CLOTHOID, CIRCLE, GEODESICSTRING, NURBSCURVE, SPIRALCURVE, and ELLIPTICALCURVE are instantiable ST_Curve subtypes, not unknown extras. No carrier. CIRCLE does not steal CIRCULARSTRING. Co-authored-by: jbloemscheer <jbloemscheer@gmail.com>
grootstebozewolf
marked this pull request as ready for review
September 2, 2026 01:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
ST_Clothoid,ST_Circle,ST_GeodesicString,ST_NURBSCurve,ST_SpiralCurve, andST_EllipticalCurveare instantiable ST_Curve subtypes in ISO/IEC 13249-3 §4.2.1. They are not optional extras. This reader used to call themUnknown type. That is a lie.Named refuse, matching GEOS: the message cites §4.2.1 and does not say
Unknown type. A genuine unknown token (NOTATYPE) still does.COMPOUNDCURVE (CLOTHOID …)hits the same refuse, notUnexpected token. CIRCLE does not steal CIRCULARSTRING (dim-suffix match, notIsTypeName).No carrier. No flatten to LINESTRING. Do not remint 508. Type-9/10/11/12 reader PRs stay out.
Pins:
CurveWktTest.SqlMmSection421TypesAreNamedRefusesNotUnknown(31 CurveWktTest passed locally).Companion Proofs letter: grootstebozewolf/NetTopologySuite.Proofs#660 (ticket 38).