Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 22, 2025

🚀 Improvement

🐛 Bug Fixes

🧰 Maintenance

@github-actions github-actions bot changed the title Preparing release pull request... Release v7.3.2 Sep 22, 2025
yuki-takei and others added 23 commits September 22, 2025 20:34
…signment

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…eak-by-yuki

support: Improve memory leak
…nt-retrieving-status

imprv: Elasticsearch management retrieving status
…ration

Fix issue where external authentication errors (like OIDC "jwks must be a JSON Web Key Set formatted object") were not displayed when password login was disabled.

The error display logic was previously contained within renderLocalOrLdapLoginForm(), which only executed when isLocalOrLdapStrategiesEnabled was true. This caused external auth errors to be hidden when password login was disabled.

Changes:
- Move all error display logic to top-level component render
- Both loginErrors and externalAccountLoginError now display consistently
- Remove duplicate error handling from renderLocalOrLdapLoginForm()
- Update useCallback dependencies to reflect simplified function scope

Fixes #9799

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
…e-9799

fix: Ensure login errors display regardless of password login configuration
@yuki-takei
Copy link
Contributor

@mergify queue

@mergify mergify bot added the queued label Sep 29, 2025
@mergify
Copy link
Contributor

mergify bot commented Sep 29, 2025

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at 2bd3823

mergify bot added a commit that referenced this pull request Sep 29, 2025
@mergify mergify bot merged commit 2bd3823 into release/current Sep 29, 2025
26 of 27 checks passed
@mergify mergify bot removed the queued label Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants