feat: General users can't access other user pages #10650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lity-setting-frontend-component feat: New global setting and frontend component for user page visibility
…-visibility-in-pagetree feat: User pages gets hidden from in the page tree when the user page visibility is set to hide
arvid-e
force-pushed
the
feat/174756-block-viewing-other-user-pages
branch
from
5a898a4 to
81d11a0
Compare
yuki-takei
requested changes
Jan 1, 2026
Contributor
現状の実装
改修案
判定についてのヒントユーザーページの判定import { isUserPage } from '@growi/core/dist/utils/page-path-utils';必要であれば、同パッケージから isUsersTopPage, isUsersHomepage, isUsersProtectedPages などを利用できる API path の判定API path かどうかは、login-required.js の以下の判定を参考にする // is api path
const baseUrl = req.baseUrl || '';
if (baseUrl.match(/^\/_api\/.+$/)) {
...
} |
yuki-takei
requested changes
Jan 6, 2026
Contributor
There was a problem hiding this comment.
v7.3 ベースのコードのように見える
master ブランチからの乖離が激しいので follow してから再実装してください
arvid-e
force-pushed
the
feat/174756-block-viewing-other-user-pages
branch
from
a9236ca to
dc1954e
Compare
yuki-takei
requested changes
Jan 8, 2026
| user?: IUser, | ||
| showPagesRestrictedByOwner?: boolean, | ||
| showPagesRestrictedByGroup?: boolean, | ||
| hideUserPages?: boolean, |
| if (isTargetUserPage) return false; | ||
|
|
||
| return true; | ||
| }); |
Contributor
There was a problem hiding this comment.
この filter もうちょっとシンプルに書ける
| }); | ||
| } | ||
|
|
||
| if (pages.length === 0 && path != null) { |
Contributor
There was a problem hiding this comment.
path != null という条件はなんのために必要なんだっけ？
arvid-e
force-pushed
the
feat/175627-admin-can-hide-user-pages
branch
from
fc136ec to
464f9d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redmine.weseek.co.jp/issues/174756
Block viewing of other user's pages when hiding user pages