Skip to content

fix: Cannot create /Sidebar page from custom sidebar #10690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 4 commits into from
Jan 13, 2026
Merged

fix: Cannot create /Sidebar page from custom sidebar #10690

mergify merged 4 commits into from
Jan 13, 2026
+16 −10

Conversation

@miya
Copy link
Member

@miya miya commented Jan 8, 2026

@miya miya requested a review from yuki-takei January 8, 2026 09:39
@miya miya self-assigned this Jan 8, 2026
miya
miya commented Jan 8, 2026
View reviewed changes
apps/app/src/client/components/Sidebar/Custom/CustomSidebar.tsx Outdated
<h3 className="fs-6 fw-bold mb-0">
{t('Custom Sidebar')}
{!isLoading && (
{!isLoading && data != null && (
Copy link
Member Author

@miya miya Jan 8, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

症状

ページが存在しない時に /Sidebar#edit に遷移できてしまっていた。遷移後にページデータは作られず、エディターからページを保存することもできなかった。

修正方法

そもそも path:/Sidebar なページが存在しない時は編集アイコンを表示させないようにした。

ページが存在していなければ「/Sidebar ページを作成する」という導線があるので、ページが存在しない時に編集アイコンを表示させるのは不要だと判断。

Image

@yuki-takei
Copy link
Contributor

yuki-takei commented Jan 8, 2026

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jan 8, 2026 •
edited
Loading

queue

❌ The pull request has been removed from the queue default

Details

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

@mergify
Copy link
Contributor

mergify bot commented Jan 8, 2026 •
edited
Loading

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at 0fa140f

This pull request spent 11 minutes 11 seconds in the queue, including 11 minutes 1 second running CI.
The checks were run on draft #10691.

Required conditions to merge
  • -check-failure ~= test-prod-node20 /
  • check-success ~= test-prod-node20 / run-playwright
  • -check-failure ~= ci-app-
  • -check-failure ~= ci-slackbot-
  • check-success = test-prod-node20 / build-prod
  • check-success ~= ci-app-launch-dev
  • check-success ~= ci-app-lint
  • check-success ~= ci-app-test
  • check-success ~= test-prod-node20 / launch-prod

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot added the queued label Jan 8, 2026
mergify bot added a commit that referenced this pull request Jan 8, 2026
@mergify
Merge of #10690
de00b52
@mergify mergify bot mentioned this pull request Jan 8, 2026
Closed
15 tasks
@mergify mergify bot added dequeued and removed queued labels Jan 8, 2026
@mergify mergify bot removed the dequeued label Jan 9, 2026
miya
miya commented Jan 9, 2026
View reviewed changes
apps/app/playwright/50-sidebar/access-to-sidebar.spec.ts
await expect(page.getByTestId('grw-sidebar-contents')).toBeVisible();
await expect(
page.locator('.grw-sidebar-content-header > h3').locator('a'),
).toBeVisible();
Copy link
Member Author

@miya miya Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Sidebar ページが存在しない時は a タグは非表示にしたため削除

@miya miya changed the title fix: Cannot create /Sidebar page from custom sidebar fix: Cannot create /Sidebar page from custom sidebar Jan 9, 2026
@yuki-takei
Copy link
Contributor

yuki-takei commented Jan 13, 2026

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2026 •
edited
Loading

queue

❌ The pull request has been removed from the queue default

Details

The merge conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2026 •
edited
Loading

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at 4a69ada

This pull request spent 10 minutes 45 seconds in the queue, including 10 minutes 32 seconds running CI.
The checks were run on draft #10702.

Required conditions to merge
  • -check-failure ~= test-prod-node20 /
  • check-success ~= test-prod-node20 / run-playwright
  • -check-failure ~= ci-app-
  • -check-failure ~= ci-slackbot-
  • check-success = test-prod-node20 / build-prod
  • check-success ~= ci-app-launch-dev
  • check-success ~= ci-app-lint
  • check-success ~= ci-app-test
  • check-success ~= test-prod-node20 / launch-prod

Reason

The merge conditions cannot be satisfied due to failing checks

Failing checks:

Hint

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify bot added the queued label Jan 13, 2026
mergify bot added a commit that referenced this pull request Jan 13, 2026
@mergify
Merge of #10690
092f098
@mergify mergify bot mentioned this pull request Jan 13, 2026
Closed
15 tasks
mergify bot added a commit that referenced this pull request Jan 13, 2026
@mergify
Merge of #10690
9f98bcf
mergify bot added a commit that referenced this pull request Jan 13, 2026
@mergify
Merge of #10690
049acd5
This was referenced Jan 13, 2026
Closed
Closed
@mergify mergify bot added dequeued and removed queued labels Jan 13, 2026
@mergify mergify bot removed the dequeued label Jan 13, 2026
@miya
Copy link
Member Author

miya commented Jan 13, 2026

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2026 •
edited
Loading

queue

✅ The pull request has been merged automatically

Details

The pull request has been merged automatically at a7c862f

@mergify
Copy link
Contributor

mergify bot commented Jan 13, 2026 •
edited
Loading

Merge Queue Status

✅ The pull request has been merged at 2f51823

This pull request spent 13 minutes 26 seconds in the queue, including 13 minutes 14 seconds running CI.
The checks were run on draft #10710.

Required conditions to merge
  • -check-failure ~= ci-app-
  • -check-failure ~= ci-slackbot-
  • -check-failure ~= test-prod-node20 /
  • check-success = test-prod-node20 / build-prod
  • check-success ~= ci-app-launch-dev
  • check-success ~= ci-app-lint
  • check-success ~= ci-app-test
  • check-success ~= test-prod-node20 / launch-prod
  • check-success ~= test-prod-node20 / run-playwright

@mergify mergify bot added the queued label Jan 13, 2026
mergify bot added a commit that referenced this pull request Jan 13, 2026
@mergify
Merge of #10690
2075293
@mergify mergify bot mentioned this pull request Jan 13, 2026
Closed
15 tasks
@mergify mergify bot merged commit a7c862f into master Jan 13, 2026
27 checks passed
@mergify mergify bot deleted the fix/176797-cannot-create-sidebar-page-from-custom-sidebar branch January 13, 2026 07:09
@mergify mergify bot removed the queued label Jan 13, 2026
@github-actions github-actions bot mentioned this pull request Jan 13, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuki-takei yuki-takei Awaiting requested review from yuki-takei

Assignees

@miya miya

Labels

type/bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@miya @yuki-takei