Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions apps/app/src/client/components/PageHeader/PageHeader.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,22 @@ export const PageHeader = (): JSX.Element => {
const pageControlsX = usePageControlsX();
const pageHeaderRef = useRef<HTMLDivElement>(null);

const [maxWidth, setMaxWidth] = useState<number>();
const [maxWidth, setMaxWidth] = useState<number>(300);

const calcMaxWidth = useCallback(() => {
if (pageControlsX == null || pageHeaderRef.current == null) {
// Length that allows users to use PageHeader functionality.
setMaxWidth(300);
if (pageHeaderRef.current == null) {
return;
}

// For mobile screens (< 576px), use full screen width
if (window.innerWidth < 576) {
const maxWidth =
window.innerWidth - pageHeaderRef.current.getBoundingClientRect().x;
setMaxWidth(maxWidth);
return;
}

if (pageControlsX == null) {
return;
}

Expand All @@ -33,6 +43,12 @@ export const PageHeader = (): JSX.Element => {

useEffect(() => {
calcMaxWidth();

// Recalculate on window resize
window.addEventListener('resize', calcMaxWidth);
return () => {
window.removeEventListener('resize', calcMaxWidth);
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

この addEventListener はパフォーマンス悪化の原因になるので消してください

useDeviceLargerThanSm を使えば re-rendering されるはず

}, [calcMaxWidth]);

if (currentPage == null) {
Expand Down
Loading