feat: Block option to include user pages in search when hiding setting is turned on #10720
+98
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-takei
requested changes
Jan 15, 2026
Contributor
There was a problem hiding this comment.
SWR ではなく、useHydrateAtoms で server configuration を Jotai atom に管理させましょう
理由は、最新のデータを何度も revalidation する必要がないコンフィグ値だからです
apps/app/src/pages/general-page/hydrate.ts で hydration 処理を追加してください
これは general pages での hydration 実装なので、/_search 向けの実装は別途必要です
Contributor
There was a problem hiding this comment.
この修正は不要、API 側で /user データを返さないようにする
Contributor
There was a problem hiding this comment.
この修正は不要、API 側で /user データを返さないようにする
| limit, | ||
| }, | ||
| isHidingUserPages, | ||
| ); |
Contributor
There was a problem hiding this comment.
この修正は不要、API 側で /user データを返さないようにする
| <SearchControl | ||
| isEnableSort | ||
| isEnableFilter | ||
| isHidingUserPages={isHidingUserPages} |
Contributor
There was a problem hiding this comment.
SearchControl に対する変更は必要
Contributor
There was a problem hiding this comment.
この修正は不要、API 側で /user データを返さないようにする
Contributor
There was a problem hiding this comment.
この修正は不要、API 側で /user データを返さないようにする
arvid-e
force-pushed
the
feat/174755-hide-user-page-search-checkbox
branch
from
c512e63 to
ab499f3
Compare
arvid-e
force-pushed
the
feat/175627-admin-can-hide-user-pages
branch
from
ce245a0 to
8fa90b2
Compare
arvid-e
force-pushed
the
feat/174755-hide-user-page-search-checkbox
branch
from
ab499f3 to
679e7aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redmine.weseek.co.jp/issues/174755
https://redmine.weseek.co.jp/issues/176379