imprv: Security settings search results redesign #9992

arvid-e · 2025-05-29T07:54:03Z

TASK
https://redmine.weseek.co.jp/issues/153742
┗https://redmine.weseek.co.jp/issues/153037

changeset-bot · 2025-05-29T07:54:07Z

⚠️ No Changeset found

Latest commit: 73d89b4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

miya · 2025-05-29T10:41:05Z

apps/app/public/static/locales/ja_JP/admin.json

+    "always_hidden": "表示しない",
+    "always_displayed": "表示する",


"displayed" と "hidden" の値と同じものなので、それらを使うようにして良さそう

… translations

yuki-takei · 2025-06-03T13:24:43Z

apps/app/src/client/services/AdminGeneralSecurityContainer.js

フィードバック: hideRestrictedByOwner のデフォルト値に関する注意

現在の実装では、DB から得られる generalSetting.hideRestrictedByOwner が undefined の場合、currentOwnerRestrictionDisplayMode が 'Displayed' となります。

サーバーから hideRestrictedByOwner が返却されないケース（値がない場合）、デフォルトで「閲覧制限が表示される」挙動になっており、意図しない情報公開（セキュリティのデグレ）リスクがあります。

推奨対応

hideRestrictedByOwner が undefined の場合は、保守的に 'Hidden' 扱いとしてください。

例:
currentOwnerRestrictionDisplayMode: generalSetting.hideRestrictedByOwner === undefined ? 'Hidden' : (generalSetting.hideRestrictedByOwner ? 'Hidden' : 'Displayed'),

この挙動・仕様をコードコメントでも明記してください

mergify · 2025-06-04T12:05:35Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #10014.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

yuki-takei · 2025-06-04T12:23:46Z

@mergify requeue

mergify · 2025-06-04T12:23:50Z

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify · 2025-06-04T12:25:08Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #10015.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

yuki-takei · 2025-06-04T13:02:19Z

@mergify requeue

mergify · 2025-06-04T13:02:23Z

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify · 2025-06-04T13:21:44Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

❌ test-prod-node20 / run-playwright (chromium, 2/2)
❌ test-prod-node20 / run-playwright (firefox, 2/2)
❌ test-prod-node20 / run-playwright (webkit, 2/2)
☑️ approve-updating-patch-version
☑️ auto-labeling
☑️ check-title
☑️ ci-pdf-converter-launch-prod
☑️ ci-slackbot-proxy-launch-prod
☑️ test-prod-node18 / report-playwright
☑️ test-prod-node18 / run-playwright

You can check the last failing draft PR here: #10018.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

…of checkbox

mergify · 2025-06-05T04:14:13Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

❌ test-prod-node20 / run-playwright (chromium, 2/2)
❌ test-prod-node20 / run-playwright (firefox, 2/2)
❌ test-prod-node20 / run-playwright (webkit, 2/2)
☑️ approve-updating-patch-version
☑️ auto-labeling
☑️ check-title
☑️ ci-pdf-converter-launch-prod
☑️ ci-slackbot-proxy-launch-prod
☑️ test-prod-node18 / report-playwright
☑️ test-prod-node18 / run-playwright

You can check the last failing draft PR here: #10026.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify · 2025-06-05T04:39:43Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

❌ test-prod-node20 / run-playwright (chromium, 2/2)
❌ test-prod-node20 / run-playwright (firefox, 2/2)
❌ test-prod-node20 / run-playwright (webkit, 2/2)
☑️ approve-updating-patch-version
☑️ auto-labeling
☑️ check-title
☑️ ci-pdf-converter-launch-prod
☑️ ci-slackbot-proxy-launch-prod
☑️ test-prod-node18 / report-playwright
☑️ test-prod-node18 / run-playwright

You can check the last failing draft PR here: #10028.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Change checkbox to dropdown menu in security settings search results

09b55d7

arvid-e requested review from miya and yuki-takei May 29, 2025 07:54

github-actions bot added the type/improvement label May 29, 2025

miya requested changes May 29, 2025

View reviewed changes

miya approved these changes May 29, 2025

View reviewed changes

arvid-e added 3 commits June 3, 2025 03:29

Address feedback: use the existing always_hidden and always_displayed…

329516f

… translations

Revert unintented change in pagecomment

d2267d0

Fix one space that was changed unintentionally

273da6c

yuki-takei requested changes Jun 3, 2025

View reviewed changes

Address feedback: default display value to hidden

aabc547

arvid-e requested a review from yuki-takei June 4, 2025 04:20

yuki-takei approved these changes Jun 4, 2025

View reviewed changes

mergify bot added a commit that referenced this pull request Jun 4, 2025

Merge of #9992

354f7c6

mergify bot mentioned this pull request Jun 4, 2025

merge queue: embarking master (c766212) and #9992 together #10014

Closed

15 tasks

mergify bot added a commit that referenced this pull request Jun 4, 2025

Merge of #9992

fda4c9d

mergify bot mentioned this pull request Jun 4, 2025

merge queue: embarking master (c766212) and #9992 together #10015

Closed

15 tasks

mergify bot added a commit that referenced this pull request Jun 4, 2025

Merge of #9992

324d008

mergify bot mentioned this pull request Jun 4, 2025

merge queue: embarking master (c766212), #9915 and #9992 together #10017

Closed

15 tasks

mergify bot added a commit that referenced this pull request Jun 4, 2025

Merge of #9992

dc3bb69

mergify bot mentioned this pull request Jun 4, 2025

merge queue: embarking master (c766212) and #9992 together #10018

Closed

15 tasks

mergify bot added a commit that referenced this pull request Jun 4, 2025

Merge of #9992

7f634ff

mergify bot mentioned this pull request Jun 4, 2025

merge queue: embarking master (c766212), #9992 and #10013 together #10019

Closed

15 tasks

Correct dropdown name and change test to work with selection instead …

adabbc3

…of checkbox

mergify bot added a commit that referenced this pull request Jun 5, 2025

Merge of #9992

f5759ac

mergify bot mentioned this pull request Jun 5, 2025

merge queue: embarking master (a3a4f95) and #9992 together #10026

Closed

15 tasks

Fix test to work with type button

b340c45

mergify bot added a commit that referenced this pull request Jun 5, 2025

Merge of #9992

f4e3c0d

mergify bot mentioned this pull request Jun 5, 2025

merge queue: embarking master (a3a4f95) and #9992 together #10028

Closed

15 tasks

Correctly test for always displayed

73d89b4

mergify bot added a commit that referenced this pull request Jun 6, 2025

Merge of #9992

789f6cb

mergify bot mentioned this pull request Jun 6, 2025

merge queue: embarking master (c4d281d) and #9992 together #10029

Closed

15 tasks

mergify bot merged commit 0d57a9d into master Jun 6, 2025
22 checks passed

mergify bot deleted the imprv/153742-security-settings-pagelist-content-improvement branch June 6, 2025 03:21

github-actions bot mentioned this pull request Jun 6, 2025

Release v7.2.6 #9988

Merged

		"always_hidden": "表示しない",
		"always_displayed": "表示する",

imprv: Security settings search results redesign #9992

imprv: Security settings search results redesign #9992

Uh oh!

Conversation

arvid-e commented May 29, 2025

Uh oh!

changeset-bot bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

miya May 29, 2025

Choose a reason for hiding this comment

Uh oh!

yuki-takei Jun 3, 2025

Choose a reason for hiding this comment

フィードバック: hideRestrictedByOwner のデフォルト値に関する注意

推奨対応

Uh oh!

mergify bot commented Jun 4, 2025

Uh oh!

yuki-takei commented Jun 4, 2025

Uh oh!

mergify bot commented Jun 4, 2025

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

Uh oh!

mergify bot commented Jun 4, 2025

Uh oh!

yuki-takei commented Jun 4, 2025

Uh oh!

mergify bot commented Jun 4, 2025

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

Uh oh!

mergify bot commented Jun 4, 2025

Uh oh!

mergify bot commented Jun 5, 2025

Uh oh!

mergify bot commented Jun 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

changeset-bot bot commented May 29, 2025 •

edited

Loading