Skip to content

Conversation

@vazarkevych
Copy link
Collaborator

Summary

Fixes ETag caching issues introduced in v1.0.9 (NetworkDispatcherKtor) and v1.0.5 (NetworkDispatcherOkHttp)

Problems

  1. 304 Not Modified treated as error — When server returns 304 (cache is valid), SDK incorrectly triggers onError callback. Since cached data is already loaded at the start, 304 simply means "cache is still valid" and requires no action.

  2. Duplicate class conflictLruETagCache class exists in both NetworkDispatcherKtor and NetworkDispatcherOkHttp modules, causing compilation error when both modules are included.

Changes

  • Handle 304 response by logging only — no callback triggered (cached data already in use)
  • Rename LruETagCache to KtorLruETagCache in Ktor module
  • Rename LruETagCache to OkHttpLruETagCache in OkHttp module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant