fix: resolve ETag caching issues (304 handling + duplicate class) #217
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ETag caching issues introduced in
v1.0.9 (NetworkDispatcherKtor)andv1.0.5 (NetworkDispatcherOkHttp)Problems
304 Not Modified treated as error — When server returns
304(cache is valid), SDK incorrectly triggersonErrorcallback. Since cached data is already loaded at the start,304simply means "cache is still valid" and requires no action.Duplicate class conflict —
LruETagCacheclass exists in bothNetworkDispatcherKtorandNetworkDispatcherOkHttpmodules, causing compilation error when both modules are included.Changes
LruETagCachetoKtorLruETagCachein Ktor moduleLruETagCachetoOkHttpLruETagCachein OkHttp module