fix: sticky bucket race condition causing JsonDecodingException crashes #219
+22
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Users are facing the issue of a
JsonDecodingExceptioncrash after updating to the6.1.3version when using thesetAttributesSyncfunction. The error shows concatenated JSON being read from the stickybucket cache.Root cause
setAttributesSyncandrefreshStickyBucketService(triggered internally by feature fetching) both callrefreshStickyBucketsSyncconcurrently without synchronization. The file-basedCachingAndroidperforms non-atomic -> delete -> create -> append, so concurrent read/write operations can produce corrupted JSONFix
Add
MutextoGBUtilsfile to synchronize all sticky bucket read/write operationsrefreshStickyBucketsSyncandsaveStickyBucketAssignment. This prevents concurrent access to cache files.Remove manual
Accept-Encodingheader inGBNetworkDispatcherOkHttpand GBNetworkDispatcherKtor. They handlegzipdecompression transparently by default.