Skip to content

fix: Add optional timeout for PoolManager #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mbush-credibly wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Add optional timeout for PoolManager #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions growthbook/growthbook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
from aiohttp.client_exceptions import ClientConnectorError, ClientResponseError, ClientPayloadError
from cryptography.hazmat.primitives.ciphers import Cipher, algorithms, modes
from cryptography.hazmat.primitives import padding
from urllib3 import PoolManager
from urllib3 import PoolManager, Timeout

from .core import _getHashValue, eval_feature as core_eval_feature, run_experiment

Expand Down Expand Up @@ -332,6 +332,8 @@ class FeatureRepository(object):
def __init__(self) -> None:
self.cache: AbstractFeatureCache = InMemoryFeatureCache()
self.http: Optional[PoolManager] = None
self.http_connect_timeout: Optional[int] = None
self.http_read_timeout: Optional[int] = None
self.sse_client: Optional[SSEClient] = None
self._feature_update_callbacks: List[Callable[[Dict], None]] = []

Expand Down Expand Up @@ -420,7 +422,10 @@ def user_agent_suffix(self, value: Optional[str]) -> None:

# Perform the GET request (separate method for easy mocking)
def _get(self, url: str, headers: Optional[Dict[str, str]] = None):
self.http = self.http or PoolManager()
timeout = None
if self.http_connect_timeout and self.http_read_timeout:
timeout = Timeout(connect=self.http_connect_timeout, read=self.http_read_timeout)
self.http = self.http or PoolManager(timeout=timeout)
return self.http.request("GET", url, headers=headers or {})

def _get_headers(self, client_key: str, existing_headers: Dict[str, str] = None) -> Dict[str, str]:
Expand Down Expand Up @@ -714,6 +719,8 @@ def __init__(
groups: dict = {},
overrides: dict = {},
forcedVariations: dict = {},
http_connect_timeout: Optional[int] = None,
http_read_timeout: Optional[int] = None,
):
self._enabled = enabled
self._attributes = attributes
Expand Down Expand Up @@ -801,6 +808,10 @@ def __init__(
self._cache_ttl, self._stale_ttl
)

if http_connect_timeout and http_read_timeout:
feature_repo.http_connect_timeout = http_connect_timeout
feature_repo.http_read_timeout = http_read_timeout

def _on_feature_update(self, features_data: Dict) -> None:
"""Callback to handle automatic feature updates from FeatureRepository"""
if features_data and "features" in features_data:
Expand Down