-
Notifications
You must be signed in to change notification settings - Fork 15
Feature/improve stickybucketing #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/fix-caching
Are you sure you want to change the base?
Feature/improve stickybucketing #167
Conversation
madhuchavva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vazarkevych Thoughtful contribution on providing File-based storage. But it involves a lot of risks that are needed to be taken care such as Concurrency bottlenecks (read-modify-write), Performance issues (full file read/write per operation) and Corruption risks (if the process crashes midway, the data is lost and the file isn't readable anymore).
On top of it, This PR replaces the current synchronous behavior for StickyBucketingService interface with async methods, which breaks the existing/custom implementations and concurrent access to a shared file needs synchronization.
Can you provide more details about this feature request?
Thank you for the review! 1. Contract Violation - resolvedChanging Fix: 2. File Storage Risks & ConcurrencyI improved ✔️ Concurrency To avoid race conditions during file-level "read-modify-write" operations, I added key-based locking using a ✔️ Safety & Integrity The implementation now operates within a 3. 💡 Feature Request BackgroundThis request originated from community needs analysis, particularly similar to the Swift SDK (Issue #116), where asynchronous support for Although in this PR we reverted to a synchronous interface for compatibility, the |
In this pr we: