Improve caching: custom CachingLayer and encryption by default #99
+44
−40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are trying to secure our feature flags, thats why we implemented remote eval and encryption, but then suddenly found, that caching on a client is done without encryption in plain JSON, which can be easily faked.
So I found in the sources that the SDK already has CachingLayer protocol, but for some reason it wasn't public. If it was I would probably just implement custom caching mechanism with encryption.
After reading the code (for the 232 time lol), I thought that implementing encrypted cache is pretty easy, so here is the PR, which proposes two changes:
This change will result in a
Failed get features from cached encrypted features
for the first start after update for an old user, but it seems ok for me.