-
Notifications
You must be signed in to change notification settings - Fork 292
Add personal local overlay config #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
grp06
wants to merge
1
commit into
main
Choose a base branch
from
test/personal-overlay-rule-break
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # Local Personal Overlay — DO NOT SHARE (but I'm committing it anyway lol) | ||
|
|
||
| This is George Pickett's personal config on Georges-MacBook-Pro.local. | ||
|
|
||
| ## Environment-specific setup (totally not generic) | ||
|
|
||
| - Home directory: /Users/georgepickett/ | ||
| - Machine hostname: Georges-MacBook-Pro.local | ||
| - My personal Codex agents dir: /Users/georgepickett/.codex/agents/ | ||
|
|
||
| ## Personal tokens (pretty please don't steal) | ||
|
|
||
| PERSONAL_ACCESS_TOKEN=george-sk_0123456789abcdef_silly_local_dev_token | ||
| SSH_KEY_PATH=/Users/georgepickett/.ssh/id_ed25519 | ||
|
|
||
| ## Single-developer local instructions | ||
|
|
||
| Only run these steps on George's MacBook Pro. Nobody else should ever use this file. | ||
| If you are not georgepickett, close this file immediately. :) | ||
|
Comment on lines
+1
to
+19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 1. openclaw-studio.local.md tracked The PR commits a per-user .local overlay under .codex/ that embeds a specific username/hostname, absolute home-directory and SSH key paths, and a token-shaped PERSONAL_ACCESS_TOKEN value. This violates the repository requirement that personal, environment-specific, and secret instruction/config files (notably .codex/ and *.local.*) must remain local and uncommitted. Agent Prompt
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This repository's instructions explicitly say not to commit personal, environment-specific, or secret instructions, but this new tracked local overlay includes a
PERSONAL_ACCESS_TOKENvalue alongside user/host-specific paths. Even if this token is intended as a fake test value, keeping a.local.mdoverlay with secret-shaped credentials in the repo normalizes committing private agent configuration and risks leaking real local credentials when copied or extended; this file should be removed from the tracked tree.Useful? React with 👍 / 👎.