simplify Level type and align with slog.Level - #818
Merged
Conversation
Contributor
Author
johanbrandhorst
left a comment
Collaborator
There was a problem hiding this comment.
One question, this looks great.
| "context" | ||
|
|
||
| "github.com/grpc-ecosystem/go-grpc-middleware/v2/interceptors" | ||
| _ "log/slog" |
Contributor
Author
There was a problem hiding this comment.
The only purpose of adding this was so that the documentation comment for the Logger interface renders the hyperlink to the slog.Level implementation.
It is non-essential and I can remove it if not required.
Collaborator
johanbrandhorst
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #738
Changes
Leveltype from a custom independent type to an alias ofslog.Levelininterceptors/logging/slog.goslog.goto reflect thatLevelis now an alias, removing the inherited documentation about level numbering constraints (which now belong to slog)Benefits
Verification
Levelalias maintains the same API surface as the previous implementationLevelDebug,LevelInfo,LevelWarn,LevelError) continue to work identicallyLoggerinterface or existing middleware implementationsLoggerFunc,DefaultClientCodeToLevel, and internal test code — all continue to work as expected