Skip to content

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Nov 12, 2025

No description provided.

@JamesNK JamesNK changed the title Update to System.CommandLine 2.0.0 Update .NET 10, System.CommandLine 2.0.0, fix warnings Nov 12, 2025
@JamesNK JamesNK force-pushed the jamesnk/systemcommandline branch from db086d0 to 7c1d006 Compare November 12, 2025 05:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project from .NET 10 preview to the release version and migrates from System.CommandLine beta to version 2.0.0, fixing associated warnings and API breaking changes.

Key Changes:

  • Updated Docker base images from .NET 10 preview to release versions
  • Migrated System.CommandLine API from beta to 2.0.0 (Option constructors, SetHandler→SetAction, AddOption→Add)
  • Replaced IConsole with custom ConsoleService abstraction

Reviewed Changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Dockerfiles Updated base images from 10.0-preview to 10.0 release
global.json Updated SDK version from preview to 10.0.100 release
Directory.Packages.props Updated package versions to release versions and System.CommandLine to 2.0.0
Program.cs files Migrated to System.CommandLine 2.0.0 API (SetAction, ParseResult, GetValue)
Command classes Updated to use ConsoleService instead of IConsole, migrated Option/Argument constructors
Test files Updated test assertions and console mocking to work with new API
ConsoleService.cs New custom console abstraction replacing System.CommandLine.IConsole
ListCommand.cs Replaced table rendering with simple text output

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JamesNK JamesNK force-pushed the jamesnk/systemcommandline branch from 8560b9f to ba4da77 Compare November 13, 2025 00:25
@JamesNK JamesNK merged commit 2e283d9 into grpc:master Nov 13, 2025
5 checks passed
@JamesNK JamesNK deleted the jamesnk/systemcommandline branch November 13, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants