-
Notifications
You must be signed in to change notification settings - Fork 4.6k
test/channelz: Don't try to dial non-dialable addresses #8782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8782 +/- ##
==========================================
- Coverage 83.29% 83.28% -0.01%
==========================================
Files 414 414
Lines 32753 32793 +40
==========================================
+ Hits 27280 27312 +32
- Misses 4070 4080 +10
+ Partials 1403 1401 -2
🚀 New features to boost your workflow:
|
5e7db39 to
b46a30e
Compare
|
Instead of failing unconditionally , would a better way be to create a And then pass the address as |
The health check goroutine could outlive a call to ClientConn.close(). Add a done channel that will be waited on when closing the transport. RELEASE NOTES: - Closing a client connection will now block until the health check goroutine completes. Signed-off-by: Tom Wieczorek <[email protected]>
ce50ee3 to
b6734d9
Compare
Right. I've tried this, and, funnily enough, when I allow the tests to dial, I encounter leak detector errors due to #8655. However, if I merge #8666 into this PR, the leak detector errors disappear. I'll mark this one as draft until #8655 has been sorted out. |
This will properly pass on cancellation requests, and reduce usage of a deprecated method. Signed-off-by: Tom Wieczorek <[email protected]>
|
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed. |
…tdialer' into clientconn-close-waitfor-goroutines
On some platforms, dialing 127.0.0.1:0 doesn't fail immediately but rather blocks until it times out. This leads to test failures because the leak detector identifies stray goroutines. Even if the tests don't need the dial to succeed, create a random listener and use that as resolved address. Signed-off-by: Tom Wieczorek <[email protected]>
b6734d9 to
179ead7
Compare
Three goroutines could outlive a call to ClientConn.close(). Add mechanics to cancel them and wait for them to complete when closing a client connection. RELEASE NOTES: - Closing a client connection will cancel all pending goroutines and block until they complete. Signed-off-by: Tom Wieczorek <[email protected]>
179ead7 to
e8e0327
Compare
|
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed. |
On some platforms, dialing 127.0.0.1:0 doesn't fail immediately but rather blocks until it times out. This leads to test failures because the leak detector identifies stray goroutines.
Even if the tests don't need the dial to succeed, create a random listener and use that as resolved address.
RELEASE NOTES: none