Skip to content

Conversation

@zhiyanfoo
Copy link

@zhiyanfoo zhiyanfoo commented Jan 15, 2026

This implements respecting the host_rewrite route action for grpc-xds clients. The grpc-proposal for this issue is here.

There was also an initial discussion here

RELEASE NOTES:

  • xds: Adds support for host_rewrite route action for grpc-xds clients. gRFC A111

@zhiyanfoo zhiyanfoo changed the title Authority rewrite literal (#19) Authority rewrite literal Jan 15, 2026
@zhiyanfoo zhiyanfoo changed the title Authority rewrite literal xds: Authority rewrite literal Jan 15, 2026
@zhiyanfoo zhiyanfoo changed the title xds: Authority rewrite literal xds: authority rewrite literal Jan 15, 2026
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

❌ Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.29%. Comparing base (25dbb81) to head (e991c20).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/testutils/balancer.go 80.00% 0 Missing and 1 partial ⚠️
internal/xds/balancer/clusterimpl/picker.go 92.30% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8838   +/-   ##
=======================================
  Coverage   83.29%   83.29%           
=======================================
  Files         414      414           
  Lines       32753    32777   +24     
=======================================
+ Hits        27280    27301   +21     
  Misses       4070     4070           
- Partials     1403     1406    +3     
Files with missing lines Coverage Δ
internal/envconfig/envconfig.go 100.00% <ø> (ø)
internal/xds/resolver/serviceconfig.go 88.32% <100.00%> (+0.17%) ⬆️
internal/xds/resolver/xds_resolver.go 88.82% <100.00%> (+0.06%) ⬆️
...nternal/xds/xdsclient/xdsresource/unmarshal_rds.go 87.84% <100.00%> (+0.09%) ⬆️
internal/testutils/balancer.go 84.09% <80.00%> (+1.80%) ⬆️
internal/xds/balancer/clusterimpl/picker.go 93.47% <92.30%> (-1.65%) ⬇️

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

grpc issue: grpc/grpc#38062

I spent a while trying to figure out whether or not ServerName should take
precedence over HostRewriteHeader. It seems that in the simplest config of a dns
resolver, ServerName is being set, even though there are docs that say it should
usually be empty.

Similarly when targeting an xDS target, ServerName is also set. So in order for
this to work HostRewriteHeader must take precedence over ServerName.

Credit to Rob for the initial version of this.
@atollena atollena added this to the 1.79 Release milestone Jan 16, 2026
@atollena atollena added Type: Feature New features or improvements in behavior Area: xDS Includes everything xDS related, including LB policies used with xDS. labels Jan 16, 2026
@atollena
Copy link
Collaborator

Closing for now, as grpc/proposal#533 needs to be approved first.

@atollena atollena closed this Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: xDS Includes everything xDS related, including LB policies used with xDS. Type: Feature New features or improvements in behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants