Skip to content

Conversation

@Jille
Copy link
Contributor

@Jille Jille commented Jan 29, 2026

It's nicer than iterating over the keys and looking up their values.

RELEASE NOTES: N/A

It's nicer than iterating over the keys and looking up their values.

RELEASE NOTES: N/A
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

❌ Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.44%. Comparing base (69b542a) to head (ee493e4).
⚠️ Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
resolver/map.go 36.36% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8867      +/-   ##
==========================================
+ Coverage   82.42%   82.44%   +0.01%     
==========================================
  Files         414      414              
  Lines       32750    32766      +16     
==========================================
+ Hits        26994    27013      +19     
+ Misses       4096     4090       -6     
- Partials     1660     1663       +3     
Files with missing lines Coverage Δ
resolver/map.go 67.64% <36.36%> (-26.61%) ⬇️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arjan-bal arjan-bal self-requested a review February 3, 2026 04:41
@arjan-bal arjan-bal self-assigned this Feb 3, 2026
Copy link
Contributor

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Jille, thanks for the contribution. In addition to being more ergonomic, the iterator approach is a nice optimization as it avoids allocating a slice for the return values.

Could you also update existing call sites of Keys() and Values() within the codebase to use the new iterator methods where it makes sense? This would help validate the new API and provide better coverage.

}
}

func (s) TestAddressMap_All(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a similar test for EndpointMap?

@arjan-bal arjan-bal assigned Jille and unassigned arjan-bal Feb 3, 2026
@arjan-bal arjan-bal added Type: Feature New features or improvements in behavior Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. labels Feb 3, 2026
@arjan-bal arjan-bal added this to the 1.80 Release milestone Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. Status: Requires Reporter Clarification Type: Feature New features or improvements in behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants