Skip to content

Conversation

@kannanjgithub
Copy link
Contributor

@kannanjgithub kannanjgithub commented Jan 23, 2026

Fix unit tests that were meant to test the case of a registered provider for a scheme returning null for the name resolver. The tests were passing even with no provider registered for the passed Uri scheme.

@jdcormie jdcormie self-requested a review January 28, 2026 05:58
@kannanjgithub kannanjgithub changed the title Remove redundant code that also has error prone flagged expressions. Fix unit tests for name resolver provider returning null for the name resolver Jan 28, 2026
@kannanjgithub kannanjgithub merged commit e636df5 into grpc:master Jan 29, 2026
16 of 17 checks passed
@kannanjgithub kannanjgithub deleted the Uri_test_remove_unusedCode branch January 29, 2026 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants