Add LB policy config message for AutoSharding - #179
Open
easwars wants to merge 3 commits into
Open
Conversation
Member
|
Please see my comments in the gRFC. There are a few changes I'd like to see here. |
Contributor
Author
Awesome. Thanks. Will address those comments and then get back here. |
easwars
changed the title
Contributor
Author
|
@markdroth : I just updated this PR with the changes from A119. PTAL Also, I was wondering about the two field names that we currently have:
Thanks |
markdroth
reviewed
Aug 12, 2026
| // "Locality" before sending. If a "%s" token is present, but the "Locality" | ||
| // information is not available to the LB policy, the token will be replaced | ||
| // with an empty string. | ||
| string slicing_target = 2; |
Member
There was a problem hiding this comment.
Yeah, I'd call this autosharding_target.
|
|
||
| // Name of the request header containing the application-defined key. This key | ||
| // is used to look up the matching key-range assigned by the sharding service. | ||
| string slice_key_header_name = 3; |
Member
There was a problem hiding this comment.
Yes, key_header_name seems like a good name for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per gRFC A119 (grpc/proposal#551).