Regenerate integration test sources from proto - #189
Merged
Conversation
Fetch updates to .proto from upstream. Fix broken path to /Generated directory. Add help script to check generated code.
samuelmurray
commented
Jul 28, 2026
|
|
||
| # Re-generate everything. | ||
| log "Regenerating protos..." | ||
| "$here"/protos/generate.sh |
Contributor
Author
There was a problem hiding this comment.
Perhaps this ought to first run fetch.sh to ensure that upstream is up-to-date?
Contributor
Author
There was a problem hiding this comment.
On the other hand, that might be too strict since it would fail builds (if this was part of PR checks) any time the upstream was updated..
Collaborator
There was a problem hiding this comment.
Yeah, that'd add a little too much noise I think.
Contributor
Author
|
Pretty sure the failing tests on |
glbrntt
approved these changes
Jul 29, 2026
|
|
||
| # Re-generate everything. | ||
| log "Regenerating protos..." | ||
| "$here"/protos/generate.sh |
Collaborator
There was a problem hiding this comment.
Yeah, that'd add a little too much noise I think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that
grpc-swift-protobufis updated, the generated code differers slightly.Other changes: