Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround nightly compiler crash #68

Merged
merged 3 commits into from
Feb 4, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,8 @@ extension GRPCChannel {
return
}

let (enqueued, loadBalancer) = self.state.withLock { state in
// Explicitly adding the types works around: https://github.com/swiftlang/swift/issues/78112
let (enqueued, loadBalancer) = self.state.withLock { state -> (Bool, LoadBalancer?) in
state.enqueue(continuation: continuation, waitForReady: waitForReady, id: id)
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import NIOCore
import NIOEmbedded
import NIOHTTP2
import XCTest

@testable import GRPCNIOTransportCore
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import GRPCCore
import GRPCNIOTransportCore
import NIOCore
import NIOHTTP2
import NIOPosix
import XCTest
Expand Down Expand Up @@ -639,7 +640,7 @@ final class GRPCChannelTests: XCTestCase {
TestServer(eventLoopGroup: .singletonMultiThreadedEventLoopGroup)
}

var addresses = [SocketAddress]()
var addresses = [GRPCNIOTransportCore.SocketAddress]()
for server in servers {
let address = try await server.bind()
addresses.append(address)
Expand Down Expand Up @@ -863,7 +864,7 @@ extension GRPCChannel.Config {
}

extension Endpoint {
init(_ addresses: SocketAddress...) {
init(_ addresses: GRPCNIOTransportCore.SocketAddress...) {
self.init(addresses: addresses)
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
* limitations under the License.
*/

import GRPCCore
import GRPCNIOTransportCore
import NIOPosix
import XCTest

enum LoadBalancerTest {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import GRPCCore
import GRPCNIOTransportCore
import NIOCore
import NIOHTTP2
import NIOPosix
import XCTest
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

import GRPCCore
import GRPCNIOTransportCore
import NIOCore
import NIOHTTP2
import NIOPosix
import XCTest
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* limitations under the License.
*/

import GRPCCore
import GRPCNIOTransportCore
import XCTest

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
* limitations under the License.
*/

import GRPCCore
import GRPCNIOTransportCore
import XCTest

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@

import GRPCCore
import GRPCNIOTransportHTTP2
import NIOCore
import Synchronization
import Testing

@Suite("ChannelDebugCallbacks")
Expand Down Expand Up @@ -96,7 +98,7 @@ struct ChannelDebugCallbackTests {

private func makeServerTransport(
kind: TransportKind,
address: SocketAddress,
address: GRPCNIOTransportCore.SocketAddress,
debug: HTTP2ServerTransport.Config.ChannelDebuggingCallbacks
) -> NIOServerTransport {
switch kind {
Expand Down
Loading