Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment StreamPriorityData frames in stream handler tests #73

Merged
merged 1 commit into from
Feb 18, 2025
Merged

Uncomment StreamPriorityData frames in stream handler tests #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Tests/GRPCNIOTransportCoreTests/Client/GRPCClientStreamHandlerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,9 @@ final class GRPCClientStreamHandlerTests: XCTestCase {
let framesToBeIgnored: [HTTP2Frame.FramePayload] = [
.ping(.init(), ack: false),
.goAway(lastStreamID: .rootStream, errorCode: .cancel, opaqueData: nil),
// TODO: uncomment when it's possible to build a `StreamPriorityData`.
// .priority(
// HTTP2Frame.StreamPriorityData(exclusive: false, dependency: .rootStream, weight: 4)
// ),
.priority(
HTTP2Frame.StreamPriorityData(exclusive: false, dependency: .rootStream, weight: 4)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to bump the minimum required http2 version as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, we're already on the latest version

),
.settings(.ack),
.pushPromise(.init(pushedStreamID: .maxID, headers: [:])),
.windowUpdate(windowSizeIncrement: 4),
Expand Down
7 changes: 3 additions & 4 deletions Tests/GRPCNIOTransportCoreTests/Server/GRPCServerStreamHandlerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,9 @@ final class GRPCServerStreamHandlerTests: XCTestCase {
let framesToBeIgnored: [HTTP2Frame.FramePayload] = [
.ping(.init(), ack: false),
.goAway(lastStreamID: .rootStream, errorCode: .cancel, opaqueData: nil),
// TODO: uncomment when it's possible to build a `StreamPriorityData`.
// .priority(
// HTTP2Frame.StreamPriorityData(exclusive: false, dependency: .rootStream, weight: 4)
// ),
.priority(
HTTP2Frame.StreamPriorityData(exclusive: false, dependency: .rootStream, weight: 4)
),
.settings(.ack),
.pushPromise(.init(pushedStreamID: .maxID, headers: [:])),
.windowUpdate(windowSizeIncrement: 4),
Expand Down
Loading