Bump grpc-swift-2 depenendency requirement #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: A recent relase of grpc-swift-2 added a few sendable annotations to the generated code. The expected code in our tests is now incorrect so CI is failing. Modifications: - Bump version - Update test expectations - Regenerate Result: CI passes
dongjoon-hyun
added a commit
to apache/spark-connect-swift
that referenced
this pull request
Dec 19, 2025
### What changes were proposed in this pull request? This PR aims to upgrade `gRPC Swift Protobuf` to 2.1.2. ### Why are the changes needed? `gRPC Swift Protobuf` 2.1.2 is the first release with tested with Swift 6.2 officially. In addition, it requires the latest `grpc-swift-2` dependency (#268). - https://github.com/grpc/grpc-swift-protobuf/releases/tag/2.1.2 - grpc/grpc-swift-protobuf#88 - grpc/grpc-swift-protobuf#91 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #270 from dongjoon-hyun/SPARK-54786. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A recent release of grpc-swift-2 added a few sendable annotations to the generated code. The expected code in our tests is now incorrect so CI is failing.
Modifications:
Result:
CI passes