test(xds): fix intermittent circuit breaking test flake by adding CDS settle duration - #274
Closed
rishesh007 wants to merge 3 commits into
Closed
test(xds): fix intermittent circuit breaking test flake by adding CDS settle duration#274rishesh007 wants to merge 3 commits into
rishesh007 wants to merge 3 commits into
Conversation
rishesh007
requested review from
pawbhard and
sreenithi
and removed request for
eshitachandwani and
kannanjgithub
August 3, 2026 06:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intermittent flakes (approx. 1-in-20 runs) in CircuitBreakingTest.test_circuit_breaking cause EMPTY_CALL in-flight RPC counts to reach ~2000 instead of settling in the expected range [950, 1010].
This occurs because backend service circuit breaker configurations (maxRequests) are patched asynchronously in GCP Traffic Director. If step 11 enables
keep-openmetadata immediately after initial connectivity is confirmed, background EMPTY_CALL traffic at 100 QPS can initiate ~2000 open RPCs before Traffic Director's CDS update propagates to the client pod. Becausekeep-openRPCs never terminate unless errored, any call opened before circuit breaking takes effect remains active indefinitely and permanently inflates steady-state in-flight counts.This change introduces _SETTLE_DURATION (10s) in step 10 to allow CDS circuit breaker configurations to propagate and settle on the client pod before enabling
keep-openmetadata.Test Instance:
grpc/core/master/linux/grpc_xds_k8s_lb