Skip to content

build: exclude test folder from package build#226

Merged
Jakeroid merged 1 commit into
gruns:masterfrom
iloveitaly:exclude-tests
Jan 7, 2026
Merged

build: exclude test folder from package build#226
Jakeroid merged 1 commit into
gruns:masterfrom
iloveitaly:exclude-tests

Conversation

@iloveitaly

Copy link
Copy Markdown
Contributor

Without this the tests/ folder is included, which will shadow a local tests/ directory.

@Jakeroid

Jakeroid commented Jan 5, 2026

Copy link
Copy Markdown
Collaborator

@iloveitaly

Thank you! Do you mean the build still has test because of this missing line?

@Jakeroid Jakeroid merged commit 61f969c into gruns:master Jan 7, 2026
8 checks passed
@Jakeroid

Jakeroid commented Jan 7, 2026

Copy link
Copy Markdown
Collaborator

@iloveitaly Thank you for your contribution!

@Jakeroid

Jakeroid commented Jan 12, 2026

Copy link
Copy Markdown
Collaborator

UPD: I was wrong. It works.

Previous Comment:

It turned out that CI would not work in this case.

We already exclude tests from the installation by having this packages=find_packages(exclude=['tests']) in the setup.py.
As for package at this point we can't do that. Maybe later on when the library will be migrate to modern package system it could be possible.

I will put changes back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants