-
Notifications
You must be signed in to change notification settings - Fork 6
Implement JASC palette save/load and core tileset I/O infrastructure #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements fundamental save and load functionality for Porytiles2 tilesets, focusing on JASC palette format support and core I/O infrastructure.
Key Features Added
JASC Palette Support:
JascPalLoaderwith full validation and error handlingJascPalSaverwith proper CRLF line endingsCore I/O Infrastructure:
FilePalLoader/FilePalSaverinterfaces for extensibilityPorymapTilesetComponentwith array-based palette storage (16 palettes)TilesetRepometatiles.binandmetatile_attributes.binError Handling & Robustness:
Code Quality Improvements:
string_utils.hpptemplate header with parsing utilitiesNoopArtifactChecksumProviderfor testingTechnical Details
Architecture Changes:
PorymapTilesetComponentnow usesstd::array<RgbaPal, 16>instead ofstd::vectorset_pal(),pal_at()) with bounds checkingProjectTilesetArtifactReader/Writerwith palette I/O capabilitiesFile Format Support:
Integration Points:
Files Changed
Testing & Validation
The debug command provides end-to-end testing of the save/load pipeline, enabling validation of:
This foundational work enables future development of the complete tileset compilation pipeline while maintaining clean architecture and comprehensive error handling.