Remove broken, stale disqus comment scripts #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This also fixes CSP errors related to loading disqus assets, as well as snowballing google assets - Comments have been closed a long time and not displayed, and I couldn't find any existing comments in the admin Ref jquery/infrastructure-puppet#54
Closed
1 task
Krinkle
approved these changes
Dec 1, 2024
There was a problem hiding this comment.
I went through about 10 of the ~15 blog posts, including the first blog post ("Updating plugins to Grunt 0.4"), "Grunt 1.0.0 rc1 released", and "Grunt 1.0.0 released"; and manually loaded the Disqus embed.js script (it was blocked because it's an HTTP-url in an HTTPS context).
They all rendered 0 Comments and Comments for this thread are now closed.. I thought that if some of them had interesting threads, that may be worth linking to manually in those post's footer from a Disqus permalink, but it doesn't seem like it was used in practice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref jquery/infrastructure-puppet#54