Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix arguments order for planfile #1739

Conversation

PertsevRoman
Copy link
Contributor

@PertsevRoman PertsevRoman commented Jun 30, 2021

This issue should fix #1271

This MR fixes args order when planfile is specified in extra_args for apply

@PertsevRoman PertsevRoman marked this pull request as ready for review June 30, 2021 22:09
@yorinasub17
Copy link
Contributor

Thanks for your contribution! However, just removing -input=false and -auto-approve isn't sufficient, because you will quickly run into the UX problem of having to handle interactive user input on multiple concurrent prompts.

In fact, this is a broken experience because all the prompts share a single stdin, so typing yes once will actually feed to all the stacks that are running. This means that, as a user, you might be approving a plan that you haven't seen yet.

Note also that the outputs from the plans for the interactive prompt will be incomprehensible because outputs from each concurrently running terraform action will be interleaved (since they all share stdout and stderr).

Given that, we can't really accept this as is because the feature is unusable unless parallelism is 1, but that is also not very practical for sufficiently large projects. To move forward, we would need a way to handle concurrent interactive prompts.

@PertsevRoman
Copy link
Contributor Author

Thank you @yorinasub17 for your answer!

So, the issue is promt handling. I was thinking that it can make sense to add the flags manually once we use suggested option.
I'll try to play with args order instead of disabling implicit flags.

@PertsevRoman PertsevRoman changed the title fix: Implement --disable-apply-extend flag fix: Fix arguments order for planfile Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terragrunt apply-all specific plan fails
2 participants