Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC for passing variables to dependencies #2760

Closed
wants to merge 2 commits into from

Conversation

juljaeg
Copy link

@juljaeg juljaeg commented Oct 17, 2023

Description

In relation to #2674.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added RFC for support for passing variables to terragrunt modules being included as dependencies.

Migration Guide

No migration needed.

@juljaeg juljaeg marked this pull request as ready for review October 17, 2023 13:14
@yhakbar
Copy link
Collaborator

yhakbar commented Aug 2, 2024

Hey @juljaeg

I'm sorry we let this RFC go stale.

We have switched to a new process for RFCs which uses GitHub issues since you created this PR. You can start one by clicking this.

Some initial feedback I have for this PR is that I'm not sure why it's useful to segment state using environment variables with Terragrunt. Most users leverage separate terragrunt.hcl files in order to achieve this segmentation, so I'd like to better understand the value add here.

I'm going to close this PR, but please feel free to create an RFC issue if this is still something that's important to you. We can work to better understand why this is valuable, and not convenient/possible in modern Terragrunt.

@yhakbar yhakbar closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants