fix: Enabling disabled tests #4312
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 WalkthroughWalkthroughThe changes update version references in test fixtures, remove skip directives from two integration tests, and adjust test logic to reflect the new versions. This re-enables previously skipped tests related to recursive references in tagged modules and ensures the tests use the latest module versions. Changes
Sequence Diagram(s)sequenceDiagram
participant TestRunner
participant Terragrunt
participant RemoteModule
TestRunner->>Terragrunt: Run TestAutoInitWhenSourceIsChanged
Terragrunt->>RemoteModule: Download module at v0.78.4
Terragrunt-->>TestRunner: Output "Terragrunt has been successfully initialized!"
TestRunner->>Terragrunt: Change source to v0.79.0 and re-run
Terragrunt->>RemoteModule: Download module at v0.79.0
Terragrunt-->>TestRunner: Output "Terragrunt has been successfully initialized!"
Possibly related PRs
Suggested reviewers
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
test/fixtures/download/remote-relative/terragrunt.hcl(1 hunks)test/integration_download_test.go(0 hunks)test/integration_test.go(2 hunks)
💤 Files with no reviewable changes (1)
- test/integration_download_test.go
🧰 Additional context used
📓 Path-based instructions (1)
`**/*.go`: Review the Go code for quality and correctness. Make sure that the Go code follows best practices, is performant, and is easy to understand and maintain.
**/*.go: Review the Go code for quality and correctness. Make sure that the Go code follows best practices, is performant, and is easy to understand and maintain.
test/integration_test.go
🔇 Additional comments (3)
test/integration_test.go (3)
3179-3180: Version reference updated to v0.78.4The code updates the version reference from a previous value to v0.78.4 in the test fixture, ensuring the test uses a more recent module version.
3190-3191: Version reference updated to v0.79.0The second version reference in the test has been updated to v0.79.0, maintaining consistency with the updated test fixtures for this test case.
3167-3200: TestAutoInitWhenSourceIsChanged test re-enabled successfullyThis test was previously disabled but has now been re-enabled with updated version references. The test verifies that Terragrunt automatically re-initializes when a module's source version changes. The changes appropriately update the version tags from older versions to more recent ones, allowing the test to run properly with the latest module references.
|
|
||
| terraform { | ||
| source = "github.com/gruntwork-io/terragrunt.git//test/fixtures/download/relative?ref=v0.77.22" | ||
| source = "github.com/gruntwork-io/terragrunt.git//test/fixtures/download/relative?ref=v0.79.0" |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Confirm version bump to v0.79.0
The source ref has been updated from v0.77.22 to v0.79.0. Ensure consistency across all fixtures and tests by checking for any remaining references to the old version.
Run:
🏁 Script executed:
#!/bin/bash
# Verify no fixtures/tests still reference the old version
rg -l 'v0\.77\.22' -g 'test/fixtures/**/*.hcl' -g 'test/**/*.go'
# Confirm new version is used everywhere
rg -l 'v0\.79\.0' -g 'test/fixtures/**/*.hcl' -g 'test/**/*.go'Length of output: 305
Update remaining fixtures referencing v0.77.22
Our search shows two fixture files still pin to the old version. Please update their source refs to v0.79.0 for consistency:
- test/fixtures/download/remote/terragrunt.hcl
- test/fixtures/download/remote-ref/terragrunt.hcl
Suggested command to verify once updated:
rg -l 'v0\.77\.22' -g 'test/fixtures/**/*.hcl' && echo "Old refs remain!"
rg -l 'v0\.79\.0' -g 'test/fixtures/**/*.hcl' && echo "All fixtures now on v0.79.0"🤖 Prompt for AI Agents
In test/fixtures/download/remote/terragrunt.hcl around line 6, the source ref
has been updated to v0.79.0, but two other fixture files still reference the old
version v0.77.22. Update the source refs in
test/fixtures/download/remote/terragrunt.hcl and
test/fixtures/download/remote-ref/terragrunt.hcl from v0.77.22 to v0.79.0 to
maintain consistency across all fixtures. After updating, run the provided
ripgrep commands to verify no old version references remain.
Description
Enabling tests that were disabled while we were moving to the new repo structure.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Enabled
TestRemoteDownloadWithRelativePathagain.Enabled
TestAutoInitWhenSourceIsChangedagain.Migration Guide
Summary by CodeRabbit
Bug Fixes
Tests