-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add output_dir to inputs in multiple sections #5334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The following was omitted starting at the dependency examples : output_dir = get_terragrunt_dir()
This was causing an error when running "terragrunt run --all plan" : │ Error: No value for required variable
│
│ on main.tf line 5:
│ 5: variable "output_dir" {}
│
│ The root module input variable "output_dir" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
|
@therealgglggl is attempting to deploy a commit to the Gruntwork Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughAdded Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs-starlight/src/content/docs/01-getting-started/01-quick-start.mdx (1)
341-351: Consider showing both foo and bar examples explicitly.While the text at line 339 correctly states "Then in your
foo/terragrunt.hclandbar/terragrunt.hclfiles...", only one example is provided. For maximum clarity, consider showing both files explicitly since they both need theoutput_dirinput after the module update:💡 Optional clarity improvement
Then in your `foo/terragrunt.hcl` and `bar/terragrunt.hcl` files, you can use the `get_terragrunt_dir()` built-in function to get the directory where the `terragrunt.hcl` file is located: +```hcl +# foo/terragrunt.hcl +terraform { + source = "../shared" +} + +inputs = { + output_dir = get_terragrunt_dir() + content = "Hello from foo, Terragrunt!" +} +``` + ```hcl +# bar/terragrunt.hcl terraform { source = "../shared" } inputs = { output_dir = get_terragrunt_dir() content = "Hello from bar, Terragrunt!" }This would help users following the tutorial understand that both files need updating, though the current version is functionally correct based on the guidance at line 57 referencing the complete examples repository. </details> </blockquote></details> </blockquote></details> <details> <summary>📜 Review details</summary> **Configuration used**: Path: .coderabbit.yaml **Review profile**: CHILL **Plan**: Pro <details> <summary>📥 Commits</summary> Reviewing files that changed from the base of the PR and between e0a2f684b6814f730732b104e98e245fb0ebf1ae and 137690edc51c87506ce05efc0b9fe02eab8bdbe3. </details> <details> <summary>📒 Files selected for processing (1)</summary> * `docs-starlight/src/content/docs/01-getting-started/01-quick-start.mdx` </details> <details> <summary>🧰 Additional context used</summary> <details> <summary>📓 Path-based instructions (1)</summary> <details> <summary>docs-starlight/**/*.md*</summary> **⚙️ CodeRabbit configuration file** > Review the documentation for clarity, grammar, and spelling. Make sure that the documentation is easy to understand and follow. There is currently a migration underway from the Jekyll based documentation in `docs` to the Starlight + Astro based documentation in `docs-starlight`. Make sure that the `docs-starlight` documentation is accurate and up-to-date with the `docs` documentation, and that any difference between them results in an improvement in the `docs-starlight` documentation. Files: - `docs-starlight/src/content/docs/01-getting-started/01-quick-start.mdx` </details> </details> </details> <details> <summary>🔇 Additional comments (3)</summary><blockquote> <details> <summary>docs-starlight/src/content/docs/01-getting-started/01-quick-start.mdx (3)</summary><blockquote> `377-390`: **LGTM! Essential addition to the dependency example.** The `output_dir` parameter is correctly added to the inputs block, which is necessary after the shared module was updated in Step 5 to require this variable. This ensures the example works when users follow the tutorial. --- `438-454`: **LGTM! Consistent addition in mock_outputs example.** The `output_dir` parameter is properly included in this variation of the bar/terragrunt.hcl configuration, maintaining consistency with the previous dependency example. --- `515-533`: **LGTM! Final consistent addition completes the pattern.** The `output_dir` parameter is correctly included in this final variation, ensuring all bar/terragrunt.hcl examples throughout the tutorial are complete and functional after the module update. </blockquote></details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
The following was omitted starting at the dependency examples : output_dir = get_terragrunt_dir()
This was causing an error when running "terragrunt run --all plan" : │ Error: No value for required variable
│
│ on main.tf line 5:
│ 5: variable "output_dir" {}
│
│ The root module input variable "output_dir" is not set, and has no default
│ value. Use a -var or -var-file command line argument to provide a value for
│ this variable.
Description
Fixes #000.
TODOs
Read the Gruntwork contribution guidelines.
Release Notes (draft)
Added / Removed / Updated [X].
Migration Guide
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.