Skip to content

Conversation

@guanglinn
Copy link
Contributor

@guanglinn guanglinn commented Apr 7, 2025

This PR makes Markor support the standard text find/search and replace adopted by many other popular text editors.

#2164 #2341

Supported features are as follows:

  1. Standard UI for text find & replace

  2. Highlight all occurrences/matches

  3. Highlight current match

  4. Move to previous/next match

  5. Match case

  6. Match whole word

  7. Use regular expression

  8. Find in selection

  9. Replace once

  10. Replace all

  11. Preserve case when replacing

@guanglinn
Copy link
Contributor Author

guanglinn commented Apr 7, 2025

Screenshot ↓

Screenshot_20250411-080021_Marder.png

@guanglinn guanglinn changed the title Add support for normal/standard text find and replace Add support for normal text find and replace Apr 7, 2025
@guanglinn guanglinn changed the title Add support for normal text find and replace Add normal text find and replace Apr 9, 2025
@gsantner
Copy link
Owner

gsantner commented Apr 14, 2025

Thanks for working on this and the screenshot! To me at least it looks quite complicated at first, user will next ask where can I replace only this highlighted one? Where can I replace all? Thats the two most important buttons to be easy recognizable

@guanglinn
Copy link
Contributor Author

guanglinn commented Apr 14, 2025

User will next ask where can I replace only this highlighted one?
Where can I replace all?

These two features have already been implemented in this PR, and these two buttons can popup tool tips, users can easily recognize it.

@guanglinn
Copy link
Contributor Author

Does this get rid of the existing search dialog for todo? Because that had multi-selection and inline search - making it easy to read through and filter todos

This feature didn't get rid of the existing search dialog for todo, it didn't affect todo.

@gsantner
Copy link
Owner

Thanks both! Also for the review harshad, seems like it's not good enough yet to unleash on users, right?

@guanglinn
Copy link
Contributor Author

Right. It works now too, but it's not as perfect in occurrence highlighting. I will take the time to improve it, probably in many days.

@gsantner
Copy link
Owner

@guanglinn
Thank you, sure feel free to take the time when it fits

@gsantner gsantner marked this pull request as draft September 18, 2025 19:50
@gsantner gsantner removed this from the Markor v2.15 milestone Sep 18, 2025
@guanglinn
Copy link
Contributor Author

guanglinn commented Sep 20, 2025

Sorry, this PR has been put on hold for a long time. I will continue to improve it in these days.

@guanglinn guanglinn marked this pull request as ready for review September 21, 2025 12:50
@guanglinn
Copy link
Contributor Author

guanglinn commented Nov 5, 2025

@guanglinn guanglinn changed the title Add normal text find and replace Add standard text find and replace Nov 6, 2025
@gsantner
Copy link
Owner

gsantner commented Nov 6, 2025

Hello guanglinn, what did you mean with visual studio code icons?

If a option viable, at Markor normal Android icon set is used

@guanglinn
Copy link
Contributor Author

guanglinn commented Nov 6, 2025

I mean, the icons used for this new find & replace are from vscode-icons, this is a open source icon set, and it's nice, so I just made a declaration here to indicate that we used it.

Screenshot_20250411-080021_Marder.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants