-
Notifications
You must be signed in to change notification settings - Fork 432
Add standard text find and replace #2559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
app/src/main/java/net/gsantner/markor/frontend/search/Occurrence.java
Outdated
Show resolved
Hide resolved
|
Thanks for working on this and the screenshot! To me at least it looks quite complicated at first, user will next ask where can I replace only this highlighted one? Where can I replace all? Thats the two most important buttons to be easy recognizable |
These two features have already been implemented in this PR, and these two buttons can popup tool tips, users can easily recognize it. |
app/src/main/java/net/gsantner/markor/activity/DocumentEditAndViewFragment.java
Outdated
Show resolved
Hide resolved
This feature didn't get rid of the existing search dialog for todo, it didn't affect todo. |
|
Thanks both! Also for the review harshad, seems like it's not good enough yet to unleash on users, right? |
|
Right. It works now too, but it's not as perfect in occurrence highlighting. I will take the time to improve it, probably in many days. |
|
@guanglinn |
|
Sorry, this PR has been put on hold for a long time. I will continue to improve it in these days. |
|
Icons are from microsoft/vscode-icons: Icons for Visual Studio Code |
|
Hello guanglinn, what did you mean with visual studio code icons? If a option viable, at Markor normal Android icon set is used |
|
I mean, the icons used for this new find & replace are from vscode-icons, this is a open source icon set, and it's nice, so I just made a declaration here to indicate that we used it. |


This PR makes Markor support the standard text find/search and replace adopted by many other popular text editors.
#2164 #2341
Supported features are as follows:
Standard UI for text find & replace
Highlight all occurrences/matches
Highlight current match
Move to previous/next match
Match case
Match whole word
Use regular expression
Find in selection
Replace once
Replace all
Preserve case when replacing