Skip to content

Conversation

@schmuli
Copy link

@schmuli schmuli commented Aug 18, 2016

If we detect changes during the apply phase, we broadcast a $ngStorageChanged event on the $rootScope.

Additionally, since we also detect any changes to the underlying storage and apply those in the same manner, this event will be broadcast when the change might have come from a different tab.

Fixes #214

@schmuli
Copy link
Author

schmuli commented Aug 18, 2016

Sorry about the formatting in the test, my VI isn't setup correctly for JS.

Also, currently I only implemented one event which will be fired for both storage services, local and session. It should be trivial to add an indicator as part of the event data from which service the event was broadcast.

@dr3am3r
Copy link

dr3am3r commented Aug 25, 2016

any update on this?

@egilkh
Copy link
Contributor

egilkh commented Aug 25, 2016

Seems like a good addition. Will merge.

@schmuli
Copy link
Author

schmuli commented Oct 27, 2016

@egilkh Any chance of getting this merged any time soon?

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants