-
Notifications
You must be signed in to change notification settings - Fork 2
Also store portfolio snapshots in USD #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
c919a1e
Switch portfolio snapshots from ETH to USD denomination
claude 41ed1d8
Only show chart when currency is set to USD
claude cb36d09
Remove unused useCurrency import
claude 868939e
Filter networth entries by usdValue on server instead of client
claude dedf43d
Support charts in both USD and ETH denomination
claude daebac5
Improve loading state
gskril 4d112cc
Preserve historical ETH networth data in charts
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import { Kysely, sql } from 'kysely' | ||
|
|
||
| export const up = async (db: Kysely<any>) => { | ||
| // Add usdValue column to networth table | ||
| await db.schema | ||
| .alterTable('networth') | ||
| .addColumn('usdValue', 'real') | ||
| .execute() | ||
| } | ||
|
|
||
| export const down = async (db: Kysely<any>) => { | ||
| await db.schema.alterTable('networth').dropColumn('usdValue').execute() | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Division by zero when USDC rate is zero
The
usdcRateToEthvalue is used as a divisor without checking if it's zero or very small. IfgetRateToEthreturns 0 (e.g., if the price oracle returns 0 for an unlisted or problematic token), this would result inInfinityorNaNbeing stored asusdValuein the database. While unlikely for USDC specifically, there's no guard against this edge case.