#225 fix checkbox not working#228
Open
tanapoln wants to merge 1 commit into
Open
Conversation
Collaborator
|
Hey @Stackle! Thanks for the PR. This is a good start, but if we're going to properly support checkboxes I think there's a whole bunch more that we'd want to do. I've made some comments inline for what I think would be steps forward. |
Collaborator
There was a problem hiding this comment.
It turns out that this is not necessary - see below for why.
Collaborator
|
Finally, if we're going to support checkboxes, we should also at least have a checkbox indicator (if not actually double-click to live-edit) supported in the collection_view as well. |
Collaborator
|
@Stackle Were you planning to address the issues, or should I try to pick it up from here? |
Collaborator
|
My bandwidth is limited here, but if folks have time to explore adding first-class boolean support, I'd be happy to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.